[Plugin: Make PDF Newspaper] Bug with categories -I ncludes aFix

  • mgnbrunty

    (@mgnbrunty)


    13 years, 5 months ago

    In make-pdf-newspaper.2.2.3 If you use raw categories of the form ?cat=XXX in your URLs, then the ? and the = both appear in the filename of the generated PDF. I note already that on line 93 of makepdf.php you are replacing / with – in the filename (to handle the pretty URL case which has slashes). If you do the same with ? and = by introducing the following two lines immediately after line 93

    $catExt = str_replace(“?”,”-“,$catExt);
    $catExt = str_replace(“=”,”-“,$catExt);

    The problem goes away.
    Simple fix, best if you do it in the codebase and put it in a new version.

    Great plugin by the way.

    Mike

    http://wordpress.org/extend/plugins/make-pdf-newspaper/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter mgnbrunty

    (@mgnbrunty)

    13 years, 5 months ago

    Actually just found and fixed another bug, and I think there is at least one more.
    I note is is Gnu Affero. Happy to contribute back the fixes. best however if they make it into the main codebase.

    Thread Starter mgnbrunty

    (@mgnbrunty)

    13 years, 5 months ago

    Second bugfix

    line 181 in the original file says
    $feed->set_feed_url(get_bloginfo( 'wpurl' ).$url.'?feed=make-pdf-newspaper');
    replace this with
    $feed->set_feed_url(get_bloginfo( 'wpurl' ).$url.(strstr($url,'?')?'&':'?').'feed=make-pdf-newspaper');

    There is a third bug in the digest stuff, but I can’t chase it down.

    Mike

    Plugin Author mhawksey

    (@mhawksey)

    13 years, 5 months ago

    Big thank you Mike! I’ve incorporated your fixes into a new version of the plugin (v2.2.4). I’ve been snowed under with other work so its fantastic to have someone tidy up my hack coding 😉

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘[Plugin: Make PDF Newspaper] Bug with categories -I ncludes aFix’ is closed to new replies.