WordPress.org

Ready to get started?Download WordPress

Forums

jQuery Slider
[resolved] Missing images, broken CSS and broken settings (4 posts)

  1. William Moraes
    Member
    Posted 2 years ago #

    • I found missing the play/pause image;
    • the navigation buttons' CSS is broken - the left navigation button is negatively and absolutely positioned at the left margin, leaving some visible pixels of the arrows image;
    • the settings panel isn't showing the boolean saved ones;
    • Pagination and navigation options aren't used at all.

    The problem around settings is the comparison made. Just to note, the plugin saves an initial true boolean for each boolean option, and uses the strings "true" and "false" in the settings page. The comparison

    <option value="true" <?php if(get_option('js_pause')) echo "selected" ?>>Yes</option>
    <option value="false" <?php if(!get_option('js_pause')) echo "selected" ?>>No</option>

    doens't work because any value different from false, "", 0 and "0" is considered true by PHP. Therefore:

    <option value="true" <?php if(get_option('js_pause')=="true") echo "selected" ?>>Yes</option>
    <option value="false" <?php if(get_option('js_pause')=="false") echo "selected" ?>>No</option>

    works. Note that the startup values must change from...

    add_option('js_pause', true);
    add_option('js_paging', true);
    add_option('js_nav', true);

    ...to:

    add_option('js_pause', "true");
    add_option('js_paging', "true");
    add_option('js_nav', "true");

    This seems to happen because WP saves values as strings. Other option is to use 0 and 1, as both will be converted to false and true, respectively.

  2. Gabriel Reguly
    Member
    Posted 2 years ago #

    Hi,

    Any updates for this?

    Or we must have a custom version of the plugin?

    Cheers,
    Gabriel

  3. William Moraes
    Member
    Posted 2 years ago #

    Hello,

    No updates so far... Yes, the option now is to "fix" by hand.

    I've started making myself one, but now I've migrated to Tumblr!

    Regards,
    William

  4. Vijay Kumar
    Member
    Plugin Author

    Posted 1 year ago #

    These all issues are fixed in version 1.4

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic