WordPress.org

Ready to get started?Download WordPress

Forums

Jetpack by WordPress.com
[resolved] Empty Sharing Page for Editor and Author (6 posts)

  1. Caspie
    Member
    Posted 1 year ago #

    As the title says I get empty Settings > Sharing option page when I am using an account with Editor or Author role.

    http://wordpress.org/extend/plugins/jetpack/

  2. Beau Lebens
    Member
    Plugin Author

    Posted 1 year ago #

    Can you check and see if you get any errors in your web server's error logs?

  3. Caspie
    Member
    Posted 1 year ago #

    So far I don't get any errors in browser or debug.log

    Tested with:

    define('WP_DEBUG', true);
    define('WP_DEBUG_LOG', true);
    define('WP_DEBUG_DISPLAY', false);
    @ini_set('display_errors',0);

    http://img688.imageshack.us/img688/57/sharing.png

    I think this happens because add_submenu_page is used with 'publish_posts' as capability argument, which editors and authors also have. Shouldn't it be changed to 'manage_options' (as later checked in: sharing.php line: 167) or even role 'administrator' instead?

    in: /jetpack/modules/sharedaddy/sharing.php, line: 51
  4. Beau Lebens
    Member
    Plugin Author

    Posted 1 year ago #

    Caspie, yes, it looks like it should be changed to 'manage_options', just like it is in the page.

    We have some different requirements on WP.com (which is where this code came from), and that capability check needs to be different there. Can you try changing that for me and confirm that it matches up with what you're expecting?

  5. Caspie
    Member
    Posted 1 year ago #

    Sorry about the delay. I have the bad practice not to check "notify me of follow-ups via email".

    Changing to 'manage_options' fixes the problem and the whole Settings tab is not shown anymore, which is the correct for roles lower than administrator.

  6. Beau Lebens
    Member
    Plugin Author

    Posted 1 year ago #

    Thanks Caspie, that has been changed in the development version, and will come out with the next release of Jetpack.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic