[Plugin: FireStorm Real Estate Plugin] Missing closing tags & invalid XHTML

catnip216
(@catnip216)

14 years, 2 months ago
In the current version (1.02.01), in widget_search.php, on line 53, you need to add a closing tag after the input for the #fsrepws-input div, otherwise it may break the theme.

Also, while we’re in this section of the file, all inputs need to be self-closing, and you ought to change some of your IDs to classes, because several of these divs may be created, and IDs are supposed to be unique. I didn’t bother with that bit on mine, because for now, I’m more concerned with it working than with it validating.

I ended up changing this:
```
if ($SFields->field_value == '') {
	echo '<input type="text" name="field-'.$SFields->field_id.'" value="">';
```
To this:
```
if ($SFields->field_value == '') {
	echo '<input type="text" name="field-'.$SFields->field_id.'" value="" /></div>';
```
http://wordpress.org/extend/plugins/firestorm-real-estate-plugin/

Viewing 7 replies - 1 through 7 (of 7 total)

FireStorm Plugins
(@wfernley)

14 years, 2 months ago

Thank you for letting me know about the missing closing tag. This has been resolved in the latest version of the plugin (1.02.2).

footune
(@footune)

13 years, 10 months ago

doesnt seem like that problem is fixed, even on latest download

dbsboy
(@dbsboy)

13 years, 9 months ago

I think I got a further fix for this thanks to catnip’s finding

aside from the one mentioned by catnip
at the end of the foreach loop we need another close div

foreach($SFields as $SFields) {
echo ‘<div id=”fsrepws-input”><div id=”fsrepws-input-title”>’.$SFields->field_name.'</div>’;
if ($SFields->field_value == ”) {
echo ‘<input type=”text” name=”field-‘.$SFields->field_id.'” value=”” /></div>’; // catnip’s fix
} else {
echo ‘<select name=”field-‘.$SFields->field_id.'”>’;
echo ‘<option value=””></option>’;
$Array = explode(‘,’,$SFields->field_value);
for($i=0;$i<count($Array);$i++) {
echo ‘<option value=”‘.$Array[$i].'”>’.$Array[$i].'</option>’;
}
echo ‘</select>’;
}
echo ‘</div>’; // <———– this one
}

hope this helps

dbsboy
(@dbsboy)

13 years, 9 months ago

Apologies, I still find problems with my last code, here’s another update. Hopefully this fixes the problem properly

foreach($SFields as $SFields) {
echo ‘<div id=”fsrepws-input”><div id=”fsrepws-input-title”>’.$SFields->field_name.'</div>’;
if ($SFields->field_value == ”) {
echo ‘<input type=”text” name=”field-‘.$SFields->field_id.'” value=”” />’; //*Changed
} else {
echo ‘<select name=”field-‘.$SFields->field_id.'”>’;
echo ‘<option value=””></option>’;
$Array = explode(‘,’,$SFields->field_value);
for($i=0;$i<count($Array);$i++) {
echo ‘<option value=”‘.$Array[$i].'”>’.$Array[$i].'</option>’;
}
echo ‘</select>’;
}
echo ‘</div>’; //*Added
}
//echo ‘</div>’; //*Removed
echo ‘<div id=”fsrepws-submit”><input type=”submit” name=”fsrepw-widget-search-submit” id=”fsrepw-widget-search-submit” value=”Search Listings”></div>’;
echo ‘</form>’;

Deborah Edwards-Onoro
(@redcrew)

13 years, 9 months ago

Just to confirm, what you changed is:

in the statement above
echo '<div id="fsrepws-submit">....

removed
echo '</div>';

and between the two right closing brackets after the
echo '</select>'

you added:
echo '</div>';

FireStorm Plugins
(@wfernley)

13 years, 8 months ago

This will be fixed in the next release of the plugin.

tmoussa
(@tmoussa)

13 years, 2 months ago

Is there any way to import csv file and inject it in to FireStorm??