Forums

[resolved] [Plugin: eShop] Bug in 2.11.2 with currency sybmol (shows two times) (6 posts)

  1. nbinstitute
    Member
    Posted 3 years ago #

    I just installed the upgrade automatically from 2.11.1 to 2.11.2
    Now, on the Product listing pages the currency symbol "$" shows up twice after the @ symbol:

    @ $$19.00

    This did not happen bofore the upgrade

  2. elfin
    Moderator
    Posted 3 years ago #

    Can you provide me with a URL so I can take a quick look.

    But could you also check that the Currency - Symbol on the eshop settings page does only contain one $.

    I can't replicate the issue on my test server, so it may be a difficult one to debug.

  3. nbinstitute
    Member
    Posted 3 years ago #

    Thanks for your quick reply
    Here is a link to the test site:
    http://www.bocadulce.com/store/

    I checked and there is only 1 dollar sign in the settings page.
    As an additional test, I purposely put in 2 dollar signs and when I do that, 4 dollar signs show up, so definitely something is double counting.

  4. nbinstitute
    Member
    Posted 3 years ago #

    I'm not a programmer, but i know the update notes mentioned something about printing currency symbols. "# Changes for printing number currency, can now be localised."

    I was looking at this line (#393) in eshop_products.php

    echo ' @ '.sprintf( _c('%1$s%2$s|1-currency symbol 2-amount','eshop'), $currsymbol, number_format($grabit['_Price '.$i],2)).'
    ';

  5. elfin
    Moderator
    Posted 3 years ago #

    Thanks for the URL, and your check.

    Found the bug, and just released 2.11.3 to fix it. The bug was in eshop-get-custom.php - I'd left the original 'currency symbol' variable, so it was being shown twice.

    You will need to let me know if you see others - I'm a bit concerned that when you tried entering 2 $ that 4 showed up!

  6. nbinstitute
    Member
    Posted 3 years ago #

    ok thanks for the quick response! I'll let you know if we do find them.

Topic Closed

This topic has been closed to new replies.

About this Topic

Tags