[Plugin: Enable Media Replace] Cancel link doesn't do anything.

  • Fred Chapman

    (@fwchapman)


    13 years, 2 months ago

    Thanks for this really useful plugin — it adds an essential feature to WordPress! I especially like being able to change the name of a file and automatically update all links to that file — it’s a great time-saver!

    I noticed a small problem. If I go into the Replace Media Upload screen and decide I don’t want to replace the file after all, clicking on the Cancel link doesn’t seem to do anything. Is it supposed to abort an upload in progress or is it supposed to exit and go back to the Media Library screen?

    Thanks again,

    Fred Chapman
    Bethlehem, Pennsylvania, USA

    http://wordpress.org/extend/plugins/enable-media-replace/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Måns Jonasson

    (@mungobbq)

    13 years, 2 months ago

    Thanks Fred!

    I think that the “Cancel”-link must have been broken some time ago. I’ll think about remapping it next time I make changes.

    The link was just supposed to take you back to the page before, the media details screen.

    Thread Starter Fred Chapman

    (@fwchapman)

    13 years, 2 months ago

    You’re very welcome! I’ll look forward to your next update and post feedback after I try it out.

    Thanks for your speedy reply, too! I always appreciate it when developers actively maintain their plugins.

    Fred

    alx359

    (@alx359)

    12 years, 9 months ago

    Came here to report the same. The problem is that sometime ago it seems a modal window was opening to do the upload, and so there’s a window.close() method to handle the closing. Now things are different.

    On enable-media-replace\popup.php ~li60:

    Instead of this:

    <a href="#" onclick="window.close();"><?php echo __("Cancel", "enable-media-replace"); ?></a>

    I changed with this to make it work:

    <a href="media.php?attachment_id=<?=$_GET["attachment_id"]?>&action=edit"><?php echo __("Cancel", "enable-media-replace"); ?></a>

    Thread Starter Fred Chapman

    (@fwchapman)

    12 years, 4 months ago

    Måns, I just tried Version 2.6 of the plugin. The cancel link actually closes my browser tab instead of taking me back to the previous page! The cancel link used to do nothing, so this is progress. 🙂 -Fred

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘[Plugin: Enable Media Replace] Cancel link doesn't do anything.’ is closed to new replies.