[Plugin: emObA – Email Obfuscator Advanced] Feature suggestion and bug fix suggestion for 1.6.5

Hi, great job on version 1.6.5. Thanks for the CSS styling stuff. It works great.

First off, I have found a bug that causes email addresses that fall at the end of a sentence to have a space inserted between the email address and the period. For example it currently displays Please email me at mail@mymail.com . when it should be Please email me at mail@mymail.com.

I have found the cause(s) of this problem are newlines inserted into the page when they shouldn’t be. There are three instances of $repaddr .= emoba_readable_email($em_email, $em_name) . "</span>\n";. To fix the problem they should read $repaddr .= emoba_readable_email($em_email, $em_name) . "</span>";. There is one instance of $repaddr .= emoba_symb_email($em_email) . "</span>\n"; which should be $repaddr .= emoba_symb_email($em_email) . "</span>"; to fix the problem.

Also, I have a suggestion on changing the default non-Javascript behavior to make it look nicer. Instead of using spaces to highlight the email address, I suggest using parentheses. For example, Please email My Name (myemail@mymail.com) for help. rather than how it is currently: Please email My Name myemail@mymail.com for help.

I suggest changing function emoba_readable_email to be

function emoba_readable_email($email="", $name="(Hover)" ) {
  $transformed_email = emoba_symb_email($email);
  $addr = '<span class="emoba-pop">' . $name . '<span ';
  $addr .= '>&nbsp;(';
  $addr .= $transformed_email . ')</span></span>';
  return $addr;
}

Thanks again for a great plugin!

-Jonathan

http://wordpress.org/extend/plugins/emoba-email-obfuscator-advanced/