WordPress.org

Ready to get started?Download WordPress

Forums

Emma Emarketing Plugin for WordPress
[resolved] Using PHP short_open_tags! (5 posts)

  1. avioli
    Member
    Posted 1 year ago #

    Using PHP short_open_tags is highly not recommended.

    File: /wp-content/plugins/emma-emarketing-plugin/admin/class-form-setup.php
    Line: 144
    Is:
    <? }
    Should be:
    <?php }

    WordPress v3.4.1; Emma Emarketing Plugin v1.0.2

    http://wordpress.org/extend/plugins/emma-emarketing-plugin/

  2. John Housholder
    Member
    Plugin Author

    Posted 1 year ago #

    Hey avioli,
    thanks for catching that!
    it's been fixed.

  3. avioli
    Member
    Posted 1 year ago #

    There are more issues I fixed:

    • Custom first and last field names (coz I'm not using firstname and lastname as fields, but name_first and name_last).
    • Confirmation response padding - textarea should not have empty spaces around its value.
    • Better api calls, because import_single_member acts a tiny bit differently now, since they moved to Python.

    If you want them - do you have a repo that I can tap in or could I give you a git patch (maybe safer :) )?

  4. avioli
    Member
    Posted 1 year ago #

    BTW, your Donate button just saves the changes, instead of going to PayPal :)

  5. John Housholder
    Member
    Plugin Author

    Posted 1 year ago #

    that would be much appreciated, avioli, please send your altered version to info@ahsodesigns.com, and tyty for the heads up on the donate button!

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic