WordPress.org

Ready to get started?Download WordPress

Forums

Custom Taxonomy Sort
[resolved] Error in Quick Edit post (8 posts)

  1. hydrowire
    Member
    Posted 3 years ago #

    When doing [Quick Edit] on Posts page, the following error occurs on every post:

    Warning: Missing argument 3 for CustomTaxonomySort::quick_edit_custom_box() in /home/mydomain/public_html/wordpress/wp-content/plugins/custom-taxonomy-sort/custom-taxonomy-sort.php on line 636
    
    Warning: Missing argument 3 for CustomTaxonomySort::quick_edit_custom_box() in /home/mydomain/public_html/wordpress/wp-content/plugins/custom-taxonomy-sort/custom-taxonomy-sort.php on line 636
    
    Warning: Missing argument 3 for CustomTaxonomySort::quick_edit_custom_box() in /home/mydomain/public_html/wordpress/wp-content/plugins/custom-taxonomy-sort/custom-taxonomy-sort.php on line 636

    Please fix it asap.

    Very useful plugin by the way.

    Thanks!

    http://wordpress.org/extend/plugins/custom-taxonomy-sort/

  2. Zack Tollman
    Member
    Plugin Author

    Posted 3 years ago #

    Thanks for reporting this bug! I will look into it today and have a fix for you if I get it figured out. In the meantime, can you answer the following for me:

    1) which version of wordpress are you using?
    2) is this happening in the admin new post or edit post screen?
    3) is it happening with posts, pages, and custom post types?

    I won't be at my computer for a bit, but will take a look when I can. Answering these questions will be really helpful. Thanks!

  3. Zack Tollman
    Member
    Plugin Author

    Posted 3 years ago #

    Hydrowire...I cannot replicate this error; however, looking at the error and given your description of the error, I can see exactly why this error would show, which is odd given that it is not showing for me.

    I've put together a fix, but I have no clue if it takes care of the matter or not. Would you be willing to test it for me? If so, can you download just or copy and paste this version (http://plugins.trac.wordpress.org/browser/custom-taxonomy-sort/trunk/custom-taxonomy-sort.php?rev=409278) of the "custom-taxonomy-sort.php" file in order to replace your current version. If it works, I'll push an official update for the plugin.

    Thanks so much!

  4. hydrowire
    Member
    Posted 3 years ago #

    Hi tollmanz,

    1. 3.2.1
    2. http://example.com/wp-admin/edit.php, you get to view all your posts here, and you can do a [Quick Edit] on each of them on the same page
    3. post and custom post type, not sure about page as I didn't check.

    My guess it could be php error reporting settings on my host, not really sure though.

    Anyway, I use your fixed version and the error is gone now. So yes, you can proceed with the official update for your awesome plugin.

    Thanks!

  5. Zack Tollman
    Member
    Plugin Author

    Posted 3 years ago #

    Thanks for the feedback hydrowire. I could quickly spot the issue. On my development setup, I have the highest level of error reporting set so that these error don't ship with the plugin. I can absolutely see why this would happen with the "quick_edit_custom_box" action, but have no clue why it's not showing up in my setup.

    Anyway, I'm glad it's fixed. It'll be a day or so before I release the official update, so go ahead and use this fix for now. I wanted to slip in one other minor edit before updating. I need a little time though to do testing to make sure I don't introduce errors with this release.

    Thanks again!

    EDIT: Could you also mark this as resolved, perhaps by editing the title to have [resolved] in it so that this does not scare people away from the plugin. Thanks!

  6. hydrowire
    Member
    Posted 3 years ago #

    Hi tollmanz,

    Welcome. Forgot to mention I also uses custom taxonomy as well.

    Take your time, quality work need no rush.

    Great job there,

    Thanks!

  7. Zack Tollman
    Member
    Plugin Author

    Posted 3 years ago #

    The custom taxonomy shouldn't affect anything. The plugin should work on all taxonomies no matter whether they are custom or built in.

    If you are interested in what the error was about, the "quick_edit_custom_box" filter is executed for each column in every WordPress list table. Interestingly, it takes 3 arguments are used when this action is executed in the term list tables and only 2 arguments are used when this action is executed in the post list tables. As such, the function that I want to run on that action accepts the 3 arguments send when the action is executed in the term list tables. The error you got was because the post list table sent 2 arguments and the function expected 3. I just added a conditional statement that prevents the call to that action outside of the term list context.

  8. Zack Tollman
    Member
    Plugin Author

    Posted 3 years ago #

    I just pushed out the official update to address this issue.

    Thanks again for your feedback! I meant to add you to the acknowledgements section, but forgot for this release. I'll have you in there next time.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic