[Plugin: Custom Field Template] Please move all style= attributes to a CSS stylesheet!

  • Mr. Shiv

    (@mr-shiv)


    12 years, 11 months ago

    I love this plugin — it’s very useful to me — but every time it’s updated (frequently!), I have to go into the plugin code and remove several style= attributes that conflict with my admin UI layout. For example, line 2436 of custom-field-template.php:

    $out .= '<div id="cft_selectbox" style="height:25px;">';

    I have to remove the style=”height:25px;” every time this plugin is updated.

    Here’s a suggestion for the next version: Use a stylesheet with ID and class selectors, instead of adding style= to the divs. Or, just remove the style attributes that are not critical, and let us style the elements the way we want to via CSS.

    Thanks!

    http://wordpress.org/extend/plugins/custom-field-template/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter Mr. Shiv

    (@mr-shiv)

    12 years, 11 months ago

    I just saw the post at http://wordpress.org/support/topic/plugin-custom-field-template-can-i-arrange-the-admin-page-with-css, which explains how to use an external stylesheet for CFT on the Admin pages. Also just noticed the ADMIN CSS area of the CFT options page.

    However, inline styles (such as style=”height:25px;”) always override styles applied via embedded or external CSS. So, could you please at least remove the admin meta-box embedded styles from this plugin on the next update? Specifically, in the insert_custom_field() function, around lines 2436 – 2466 in custom-field-template.php. Then I could just use the ADMIN CSS options to fix the meta box the way I like it.

    Thanks!

    proximity2008

    (@proximity2008)

    12 years, 11 months ago

    You can use !important in your style sheet to override inline styling.

    CSS:

    #cft_selectbox {
height: 10px !important; /* or whatever else you want */
}

    This will save you from having to edit the plugin, but yeah I agree this inline styling should be removed.

    Thread Starter Mr. Shiv

    (@mr-shiv)

    12 years, 11 months ago

    D’oh! I always forget about !important. Thanks for the reminder.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘[Plugin: Custom Field Template] Please move all style= attributes to a CSS stylesheet!’ is closed to new replies.