Posted 1 year ago #
can't navigate to other months. Your jQuery is not using noConflict -- you're getting a Uncaught TypeError: Property '$' of object [object DOMWindow] is not a function error in eventdisplayer.js
http://wordpress.org/extend/plugins/custom-event-espresso-list-displayer/
Posted 1 year ago #
Hi Chris,
I've just made a small amendment to the .js file. Please try this again and let me know if this works. Can you provide a link?
Daryl
Posted 1 year ago #
I'm working on a local MAMP install -- my live test site doesn't have enough events to be a good example.
The updated js file didn't do it. Still throwing the errors. I was able to fix that by replacing all the $s with jQuery like this:
jQuery(document).ready(function(){
var tabContainers = jQuery('#month_holder > div');
jQuery('div.entry-content ul li a').click(function () {
tabContainers.hide();
tabContainers.filter(this.hash).show();
jQuery('div.entry-content ul li').removeClass('active');
jquery(this.parentNode).addClass('active');
return false;
});
});
but found another but here:
$month_html .= '<li class="<!--class_name-->">'.$month_name_abr.'';
You've got an <li> and you're giving it a class, but you never actually define the class. This wouldn't be a problem if jQuery was adding its own classes there, but it's not. And I'm pretty sure it's not because you're telling jQuery to look in div.entry-content ul li a but I don't have any div in my theme called .entry-content. (One could argue that that's my problem, but then you're pigeon-holing your plugin to work on only a few specific themes.
Posted 1 year ago #
*found another bug. DIdn't find another 'but'.
Posted 1 year ago #
Confirmed. When I replace the div.entry-contentwith the applicable code for me (section.entry) it works (sort of, but I'll get to that in a minute). Your best bet is wrapping your content in your own div and using that that way you can use whatever class you want.
The 'sort of' qualifier is that when I do click on the months, it jumps me down the page which is jarring and kind of ugly, besides the fact that where I get left is right below the month display, meaning I can't even be sure I went to the right place until I scroll back up . I made a screencast of what it's doing so you can see what I'm talking about.
http://screencast.com/t/Wp4b1VUkK
As a sidenote, I work for Event Espresso and found your plugin this morning. We were talking about it and think what you're doing is cool, so definitely interested in seeing this plugin improve :) I have another thought/suggestion but I will hold off until later ;)
Posted 1 year ago #
Hey Chris,
Thanks for dropping the source and a screencast. This definitely helped me pick out the issues.
I have defined the wp_enqeue_script for JQuery as well as running the noConflict function. For me, this works. I’ve even set up a test domain on my server to make sure that a complete fresh install doesn’t cause any surprises.
As for the div.entry-content ul li a, this was just sloppy. I already had a div defined and I am not sure why I did not use it. Lack of coffee perhaps. This has also been corrected.
I’m hoping the combination of fixes (above) will stop your page from dropping down, thus forcing you to scroll back to the top. If not, well i’ll have another re-think.
That’s interesting that you work for Event Espresso. I was discussing with my partner whether you would pick this up. By all means if you want to discuss and possible extensions I am all ears. But maybe once I’ve got the core JQuery problems sorted first.
Cheers.
Daryl.
Posted 1 year ago #
I'll take a look today. We're integrating support for jQuery Themeroller in EE 3.2, and you might think about doing something along those lines too (maybe just using it for the class/id names so if someone has it activated, it will style the css accordingly), otherwise the pink sort of overrides any possible theme styling unless someone goes in and changes it in their theme or the plugin's css.
Email me and/or Seth at my first name (at) eventespresso (dot) com (or Seth (at) eventespresso (dot) com) and we can talk about potentially helping each other out.
Posted 1 year ago #
Yeah, the jumping issue is resolved and everything is working as it should be :)
You might consider doing a CSS3 transition to do a fade in when your switching to a new month. Purely a cosmetic thing but it would look sweet (I have a thing for CSS transitions ;)
http://www.alistapart.com/articles/understanding-css3-transitions/
This topic has been closed to new replies.
