WordPress.org

Ready to get started?Download WordPress

Forums

Constant Contact WordPress Widget
[resolved] Credit link defaults to enabled (10 posts)

  1. Brad Williams
    Member
    Posted 3 years ago #

    The credit link in the widget defaults to enabled, which is a direct violation of the Plugin Directory rules. http://wordpress.org/extend/plugins/about/

    I've reported this to WP.org

    http://wordpress.org/extend/plugins/constant-contact-signup-form-widget/

  2. Zack Katz
    Member
    Plugin Author

    Posted 3 years ago #

    That was a bug that I fixed within a day of releasing a major upgrade. Versions 2.0.1+ don't have that bug. If they do, let me know and I'll fix it.

    I'm frustrated that rather than contacting me first you went directly to WordPress admins.

  3. Brad Williams
    Member
    Posted 3 years ago #

    No you didn't. You default 'credit' to '' and then check if it equals 'no' and if not you show the credit link.

  4. Brad Williams
    Member
    Posted 3 years ago #

    Which introduces another issue. If the user isn't using the widget the credit link still shows up with no way to disable it because there is no settings page for your plugin, it's all controlled in the widget

  5. Zack Katz
    Member
    Plugin Author

    Posted 3 years ago #

    Hey Brad, you might want to try looking at the MOST RECENT VERSION of the plugin. That was the bug I fixed.

    Now the code reads:

    $credit = false;
    foreach($settings as $s) { if($s['credit'] == 'yes') { $credit = true; } }
  6. Zack Katz
    Member
    Plugin Author

    Posted 3 years ago #

    Upgrade you're plugin and stop complaining. Look at the changelog:

    = 2.0.1 =
    * Fixed bug where widget would display the form before the widget had been properly configured
    * Fixed a bug where the "Give thanks" link would show up even if "Give thanks" option had not been checked. Sorry about that!

  7. Brad Williams
    Member
    Posted 3 years ago #

    Glad to see its fixed. This isn't the first time I've had problems with the credit link and this plugin. I've removed it from all sites I admin.

  8. Zack Katz
    Member
    Plugin Author

    Posted 3 years ago #

    If you looked at the code, you would realize that you can modify the "Give Thanks" output by adding a constant_contact_link filter.

  9. Brad Williams
    Member
    Posted 3 years ago #

    Can I modify the comment attribution text you put in the source of every site using your plugin (that disables the credit link)? Absolutely not.

  10. Zack Katz
    Member
    Plugin Author

    Posted 3 years ago #

    If you're that concerned with an HTML comment on a free widget, why don't you make your own? Or how about commenting out add_action('wp_footer', array(&$this, 'footer')); and calling it a day?

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic