WordPress.org

Ready to get started?Download WordPress

Forums

T(-) Countdown
[resolved] plugin conflict with Leaflet Maps Marker (11 posts)

  1. RobertHarm
    Member
    Posted 1 year ago #

    Hi,
    I am the developer of the "Leaflet Maps Marker"-plugin (www.mapsmarker.com) and found that your plugin is breaking my settings panel as you are loading an old version of jquery-ui-css on all admin pages. I kindly advice you to change your plugin in a way that the scripts and css you need for your plugin are only loaded on your admin pages. For a workaround, I will deenqueue your css files on my admin pages, but I´d be happy if you could fix this the other way round ;-)
    best regards,
    Robert

    http://wordpress.org/extend/plugins/jquery-t-countdown-widget/

  2. Baden
    Member
    Plugin Author

    Posted 1 year ago #

    Yikes! Will do, mate. Thanks.
    Update: Ok, after looking to this a bit, it seems plugin developers need to bundle their own themes for jQuery UI, which is clearly a mess when it comes to cross-plugin compatibility

    The only solution I can think of is to embrace a single theme that everyone should use on their plugins.

    So a few questions for you:

    1. Which jQuery UI theme are you using, and are you loading it locally or from Google's CDN?
    2. When you wp_register_style which name are you using? Maybe if we standardize on both the css and the registered style name, we can avoid conflicts.

    In the mean time, we'll check out your plugin and figure out the best way to get them to play well together in the sandbox.

  3. RobertHarm
    Member
    Posted 1 year ago #

    thanks!

  4. Baden
    Member
    Plugin Author

    Posted 1 year ago #

    Alright, it seems leaflet-maps-marker is including the css with the plugin.
    The css we are loading is:
    http://ajax.googleapis.com/ajax/libs/jqueryui/1.8/themes/base/jquery-ui.css
    which as you can see will auto-update to the current version:jQuery UI - v1.8.24 - 2012-09-28 as of this writing.

    Since we are using the jQuery datepicker only on the widget options, we'll see if we and check for this page and only load the datepicker / css on this page.

    More to come...

  5. Baden
    Member
    Plugin Author

    Posted 1 year ago #

    Install version 2.2.10a from the Plugin Oven: http://plugins.twinpictures.de/plugins/t-minus-countdown/

    See if that solves the datepicker conflict and let me know your results.

  6. RobertHarm
    Member
    Posted 1 year ago #

    no quite there - with 2.2.10a my css looks fine now, but the functionality is still broken because of the js-files (which cant be dequeued because of lacking ids now).

    Have a look at https://github.com/robertharm/Leaflet-Maps-Marker/blob/dev/leaflet-maps-marker.php, line 334-362 - this is how I add my js+css files only on my plugin backend pages...

  7. Baden
    Member
    Plugin Author

    Posted 1 year ago #

    which js files are you having a conflict with? I have your plugin installed on our test server. Where exactly does the conflict exist? How can we test it on our end so we don't end up playing try-this ping-pong?

  8. RobertHarm
    Member
    Posted 1 year ago #

    I dont know which of your js is causing this (as I couldnt remove it via deenqueue ;-)

    here´s how to check: install my plugin, go to settings and see if you can switch to another tab or pane. With 2.2.10a, this is broken.

  9. Baden
    Member
    Plugin Author

    Posted 1 year ago #

    Ah, ok! Install version 2.2.10b from the Plugin Oven: http://plugins.twinpictures.de/plugins/t-minus-countdown/
    And that should fix it!

    Thanks again for the feedback!

    Gruß aus Hamburg

  10. RobertHarm
    Member
    Posted 1 year ago #

    thanks - this version solves the problem. So I can remove your plugin from my list of incompatible plugins :-)

  11. Baden
    Member
    Plugin Author

    Posted 1 year ago #

    sweet. issue resolved. Will issue an update in the next days.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic