WordPress.org

1. Daniel Fru?y?ski (sirzooro)
   Member
   Posted 2 years ago #

   Changelogger does not work with 3.0-beta2-14769 - changelogs are not displayed for updated plugins. Additionally WP shows following PHP warnings on top of plugins page:

   ( ! ) Notice: Undefined offset: 0 in C:\wordpress-dev.local\wp-includes\plugin.php on line 747
   Call Stack
   #	Time	Memory	Function	Location
   1	0.0350	459280	{main}( )	..\plugins.php:0
   2	0.0385	561496	require_once( 'C:\wordpress-dev.local\wp-admin\admin.php' )	..\plugins.php:10
   3	1.6387	26427704	do_action( 'admin_init', ??? )	..\admin.php:93
   4	1.6464	26449776	call_user_func_array ( array (0 => class Changelogger { public $textdomain_loaded = TRUE }, 1 => 'init'), array (0 => '') )	..\plugin.php:395
   5	1.6464	26449936	Changelogger->init( '' )	..\plugin.php:0
   6	1.6470	26451792	add_action( 'admin_head', NULL, ???, ??? )	..\changelogger.php:116
   7	1.6470	26452128	add_filter( 'admin_head', NULL, 10, 1 )	..\plugin.php:325
   8	1.6470	26452768	_wp_filter_build_unique_id( 'admin_head', NULL, 10 )	..\plugin.php:68
   
   ( ! ) Notice: Undefined offset: 0 in C:\wordpress-dev.local\wp-includes\plugin.php on line 765
   Call Stack
   #	Time	Memory	Function	Location
   1	0.0350	459280	{main}( )	..\plugins.php:0
   2	0.0385	561496	require_once( 'C:\wordpress-dev.local\wp-admin\admin.php' )	..\plugins.php:10
   3	1.6387	26427704	do_action( 'admin_init', ??? )	..\admin.php:93
   4	1.6464	26449776	call_user_func_array ( array (0 => class Changelogger { public $textdomain_loaded = TRUE }, 1 => 'init'), array (0 => '') )	..\plugin.php:395
   5	1.6464	26449936	Changelogger->init( '' )	..\plugin.php:0
   6	1.6470	26451792	add_action( 'admin_head', NULL, ???, ??? )	..\changelogger.php:116
   7	1.6470	26452128	add_filter( 'admin_head', NULL, 10, 1 )	..\plugin.php:325
   8	1.6470	26452768	_wp_filter_build_unique_id( 'admin_head', NULL, 10 )	..\plugin.php:68
   
   ( ! ) Notice: Undefined offset: 0 in C:\wordpress-dev.local\wp-includes\plugin.php on line 747
   Call Stack
   #	Time	Memory	Function	Location
   1	0.0350	459280	{main}( )	..\plugins.php:0
   2	0.0385	561496	require_once( 'C:\wordpress-dev.local\wp-admin\admin.php' )	..\plugins.php:10
   3	1.6387	26427704	do_action( 'admin_init', ??? )	..\admin.php:93
   4	1.6464	26449776	call_user_func_array ( array (0 => class Changelogger { public $textdomain_loaded = TRUE }, 1 => 'init'), array (0 => '') )	..\plugin.php:395
   5	1.6464	26449936	Changelogger->init( '' )	..\plugin.php:0
   6	1.6519	26476752	add_action( 'admin_head', NULL, ???, ??? )	..\changelogger.php:117
   7	1.6519	26477088	add_filter( 'admin_head', NULL, 10, 1 )	..\plugin.php:325
   8	1.6519	26477728	_wp_filter_build_unique_id( 'admin_head', NULL, 10 )	..\plugin.php:68
   
   ( ! ) Notice: Undefined offset: 0 in C:\wordpress-dev.local\wp-includes\plugin.php on line 765
   Call Stack
   #	Time	Memory	Function	Location
   1	0.0350	459280	{main}( )	..\plugins.php:0
   2	0.0385	561496	require_once( 'C:\wordpress-dev.local\wp-admin\admin.php' )	..\plugins.php:10
   3	1.6387	26427704	do_action( 'admin_init', ??? )	..\admin.php:93
   4	1.6464	26449776	call_user_func_array ( array (0 => class Changelogger { public $textdomain_loaded = TRUE }, 1 => 'init'), array (0 => '') )	..\plugin.php:395
   5	1.6464	26449936	Changelogger->init( '' )	..\plugin.php:0
   6	1.6519	26476752	add_action( 'admin_head', NULL, ???, ??? )	..\changelogger.php:117
   7	1.6519	26477088	add_filter( 'admin_head', NULL, 10, 1 )	..\plugin.php:325
   8	1.6519	26477728	_wp_filter_build_unique_id( 'admin_head', NULL, 10 )	..\plugin.php:68

   http://wordpress.org/extend/plugins/changelogger/

2. Alphawolf
   Member
   Posted 2 years ago #

   sirzooro, thanks for letting me know. I'll dig into this. ;)

3. Alphawolf
   Member
   Posted 2 years ago #

   UPDATE

   I just took a quick look on my local install (3.0-beta2-14769) and it displays the changelogs for me on /wp-admin/plugins.php.

   Are you sure you allow remote requests in your local PHP installation?

   On a side note, the PHP Notices are coming from wp-includes\plugin.php, nothing related to my plugin IMHO. Do they keep showing up for you if you deactivate the 'Changelogger' plugin?

4. Daniel Fru?y?ski (sirzooro)
   Member
   Posted 2 years ago #

   No, I do not block. Changelogger works fine on my local 2.9 install. On 3.0 WP displays informations about available plugin updates, but Changelogger does not.

   I did some debugging and found that this is causes by following check on line 142:
   if (!isset($current->response[$file])) return false;

   I also found that notices are caused by code in lines 116 and 117 - wp_enqueue_script and wp_enqueue_style does not return anything, so empty value is passed as 2nd param to add_action() calls, what later triggers these notices.

5. Alphawolf
   Member
   Posted 1 year ago #

   Version 1.2.9 should fix this issue for 3.0. Sorry it took so long.

6. Daniel Fru?y?ski (sirzooro)
   Member
   Posted 1 year ago #

   New plugin version shows changelogs correctly, thanks :)

   Unfortunately PHP still displays these warnings when WP is in debug mode. Could you fix them? You can find proposed solution in my previous reply.

7. Alphawolf
   Member
   Posted 1 year ago #

   sirzooro, I'll have a look at it.

8. Daniel Fru?y?ski (sirzooro)
   Member
   Posted 1 year ago #

   Thanks! It works fine now.

Topic Closed

This topic has been closed to new replies.