WordPress.org

Ready to get started?Download WordPress

Forums

Button It Up
[resolved] Bugs & Suggestions (6 posts)

  1. mrwweb
    Member
    Posted 2 years ago #

    Paris,

    Thanks for making this plugin! After reading your article a while ago, I went and wrote this exact plugin but luckily found yours before I submitted it to the repository. No need for more than one of these.

    I checked out the plugin and discovered one bug and a few ideas :)

    The Bug
    You're styling the div#wp-content-media-buttons rather than a#content-add_media. That leads to ALL media buttons (like the Gravity forms icon) to show up in one weird integrated "button." See here: Weird button with Gravity Forms. If you change the element you're styling to the link instead, you'll also catch the Quick Press's "Insert Media" button which is currently unstyled. It's tempting to style ALL links in that row, but I'd shy away from that on the chance that other plugins style their own buttons.

    Some Tweaks

    • Style-wise, I wish the :hover and :active states more closely matched WordPress's defaults.
    • To get really nit-picky, the WordPress admin button's have a border-radius of 11px.
    • To make things a little more WordPress friendly, I'd use wp_enqueue_styles() hooked to the admin_enqueue_scripts hook to register the stylesheet.

    So thanks again for making the plugin. If you incorporate these changes, I'll definitely be adding it to all my client sites.

    http://wordpress.org/extend/plugins/button-it-up/

  2. parisvega
    Member
    Plugin Author

    Posted 2 years ago #

    Awesome feedback!

    Thank you!

    I'll get right on these changes and let you know when its updated.

  3. parisvega
    Member
    Plugin Author

    Posted 2 years ago #

    I've made the changes, just have to update the repository now.

  4. parisvega
    Member
    Plugin Author

    Posted 2 years ago #

    Hey mrwweb,

    The plugin has been updated with your requested changes: http://wordpress.org/support/plugin/button-it-up

    Let me know if it works for you.

    Thanks!

  5. mrwweb
    Member
    Posted 1 year ago #

    Hey Paris,

    This is late, huh? Sorry about that.

    I'm still getting the gravity forms bug mentioned in the earlier report: http://mrwweb.com/files/button-it-up-bug1.png

  6. parisvega
    Member
    Plugin Author

    Posted 1 year ago #

    I'm looking into the issue and will update soon.

    Thanks!

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic