WordPress.org

Ready to get started?Download WordPress

Forums

BuddyPress Group Email Subscription
Subscription status and options are shown in the group (16 posts)

  1. yannlossouarn
    Member
    Posted 2 years ago #

    Subscription status and options are shown in the groups listing and group description pages, with a "Close" button. In the code, the div class is "group-subscription-div".

    The problem notably appears with the bp-default theme, but also other themes I tested. No one noticed this ?

    http://wordpress.org/extend/plugins/buddypress-group-email-subscription/

  2. Boone Gorges
    Moderator
    Plugin Author

    Posted 2 years ago #

    I don't understand the problem. Subscription status/options are there by design. Can you be more specific about what the problem is?

  3. yannlossouarn
    Member
    Posted 2 years ago #

    Hi Boone, I Twitpic'ed you a snapshot on Twitter... :)

  4. Boone Gorges
    Moderator
    Plugin Author

    Posted 2 years ago #

    It looks like the javascript isn't loading correctly. Look at the source of your page and see if a file called bp-activity-subscription-js.js is being loaded. Also, make sure it's being loaded after jQuery.

  5. yannlossouarn
    Member
    Posted 2 years ago #

    Hi Boone, it's not loaded at all...

    I checked the active theme was bp-default, and deactivated all plugins except Buddypress 1.5.1 and BuddyPress Group Email Subscription 2.9.6. It still behaves the same.

    Could it be relate to lower level settings, like server configuration ? I mean PHP version, etc. ?

    My WordPress is a 3.2.1.

  6. yannlossouarn
    Member
    Posted 2 years ago #

    Hello !

    I made some additional tests... Among 4 setups I tested, 3 do have the described bug, and 1 does not. The PHP version is not the cause (the instance that works ok is under PHP 5.2.x, and the bug occurs on an 5.3.8 setup). But I really do not not any significant difference, beside of this... :/

    This bug is making me crazy : BP GES is really a major piece of code for me (I'm convinced it should be integrated as a basic feature in BP), and I cannot imagine running a BP-based site without it... :/

    Any idea ? HEEEELP !

    Bye,
    Yann

  7. Boone Gorges
    Moderator
    Plugin Author

    Posted 2 years ago #

    Are your four different setups all running the same theme?

  8. yannlossouarn
    Member
    Posted 2 years ago #

    Almost... Except the production site, which uses a child-theme based on bp-default, I configured the three development setups to use directly bp-default.

  9. Boone Gorges
    Moderator
    Plugin Author

    Posted 2 years ago #

    So is there a pattern between the theme and the sites where you're having the problem? Is it broken on each bp-default?

  10. yannlossouarn
    Member
    Posted 2 years ago #

    No, no pattern at all : I have both a platform with BP-Default that does not trigger the bug, and another one with the same theme, that does.
    I can open you an account, if you want to have a look by yourself...

  11. yannlossouarn
    Member
    Posted 2 years ago #

    Hmm... In fact the only pattern that may exist (but it would have to be confirmed) is that the bug *may* only exist on platforms that have been built on a WP2.8.6 + BP1.x setup. My fresh development setups are behaving ok, whereas the official dev platform and production platorm, which have been updated, do fail.
    Interested in a test account ?

  12. Boone Gorges
    Moderator
    Plugin Author

    Posted 2 years ago #

    Hard to imagine that having upgraded would be causing any problems. You can create me a test account if you want, though I'm not sure how much I'll be able to help.

  13. Boone Gorges
    Moderator
    Plugin Author

    Posted 2 years ago #

    It's pretty hard to guess what's going on based just on what I can see by logging into your site. But here's something to test. In wp-content/plugins/buddypress-group-email-subscription/bp-activity-subscription-main.php, find the line (around line 16) that says

    bp_register_group_extension( 'Group_Activity_Subscription' );

    Move that line so that it appears just before the ?> at the end of the file. Save the file and refresh your page, and see if everything loads correctly.

  14. yannlossouarn
    Member
    Posted 2 years ago #

    It works... :) But wait... does that mean we'd have to patch the plugin each time there's an update? Or is there a way you could change the plugin in order to make it work in our context ?

  15. Boone Gorges
    Moderator
    Plugin Author

    Posted 2 years ago #

    > Or is there a way you could change the plugin in order to make it work in our context ?

    In theory, yes, but in practice, no. I have identified where your problem is, but not what's causing it, so I'm afraid I don't know what to fix.

  16. yannlossouarn
    Member
    Posted 2 years ago #

    Hi Boone,

    Well... In fact this is not fully satisfactory, from an intellectual point of view, but it seems moving the following code to the very end of the file (before the closing php mark, of course... ;) ) makes it run like a charm.

    if ( defined( 'BP_VERSION' ) && version_compare( BP_VERSION, '1.5-beta-1', '<' ) ) {
    // Pre-1.5 versions of BuddyPress

    // Load the abstraction files, which define the necessary 1.5 functions
    require_once( dirname( __FILE__ ) . '/1.5-abstraction.php' );

    // Load the group extension in the legacy fashion
    add_action( 'init', 'ass_activate_extension' );
    } else {
    // Load the group extension in the proper fashion
    bp_register_group_extension( 'Group_Activity_Subscription' );
    }

    Would you mind making this change on the thunk version ?

    Best regards,
    Yann

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic