WordPress.org

Ready to get started?Download WordPress

Forums

Basic Google Maps Placemarks
[resolved] Map not loading after update (25 posts)

  1. majato
    Member
    Posted 1 year ago #

    I have updated to the latest version of bgmp and now my maps are not loading.

    My site was working perfectly fine before hand and I did not updated any other plugins at the same time.

    I've spent the last 3hours searching forn answers and trying to get this resolved but to no avail.

    Here's one of the pages where a map should be.
    http://www.norfolkplaces.com/indoor-soft-play/
    On this page I have this shortcode:-
    [bgmp-map categories="indoor-soft-play"]

    Category based maps on my site is a key feature, so unfortunately it looks like I'll have to search for a more reliable plugin if I can't get this resolved soon.

    http://wordpress.org/extend/plugins/basic-google-maps-placemarks/

  2. majato
    Member
    Posted 1 year ago #

    Luckily I had taken a back-up of my site a couple of days ago so I've reinstalled the files from the previous version of this plugin.

    Not really a resolution, so I guess I'll wait until the compatability/bug issues in v1.9 are sorted.

  3. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Hi Majato, I noticed you're using W3 Total Cache; did you clear the cache after the upgrade? If not, that would probably cause it to break, since there were some changes to the directory structure.

    Also, make sure you clear your browser cache, since old data in your browser would make it fail for you, even though it worked for people with clean caches.

    Do you have a staging site you can test out the upgrade on? I'll need to see the actual problem in order to troubleshoot it.

    I tested the plugin on my and didn't find any bugs, and also issued a release candidate two weeks ago, and nobody raised any issues.

    If your site requires 100% uptime, then I'd recommend hiring a developer who can test out early releases of the plugin on a staging server, and then submit patches for any bugs that were found in the plugin, the theme or other plugins. Then, the final release should also be tested on a staging server before being installed on the production server.

    You can't expect someone who's already given you hundreds of hours of free work to also perform exhaustive testing and extensive support.

  4. magic_square
    Member
    Posted 1 year ago #

    Hi Ian, I have the same problem as majato - maps not loading after updating to v1.9.1 that worked well before the update. I'm also using 4.3.2 and W3TC, but clearing all caches (and on the browser) has not resolved the problem.

    I'm just in the process of setting up a staging server, so on a clean Wp install with 2011 theme (and no other plug-ins) I get a loaded map but the same error:-

    "Basic Google Maps Placemarks shortcode error: is not a valid category."

    The short code I am using is [bgmp-map center="uxbridge uk" zoom="13" height="300" width="750"], so is a category now a required field?

    live site: http://www.pilates4life.co.uk/courses/maps

    Thanks for all your help

  5. majato
    Member
    Posted 1 year ago #

    Hi Ian,

    Yeah, I cleared the cache. AFter the bug occurred I read through the FAQs etc which mentioned about issues with W3.

    I don't have an upto date staging site but I was planning to build one next weekend, so will have to move my plans forward.

  6. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Thanks for the details magic_square. I was able to reproduce the bug in 1.9.1 that caused that, and fixed it in 1.9.2.

    Can you please try upgrading and let me know if you have any more problems?

    Also, I noticed that your page is including the Google Maps API twice, which may cause other problems. It's probably being included the second time from the theme or another plugin.

  7. magic_square
    Member
    Posted 1 year ago #

    Thanks for the fast update Ian. Have upgraded and error message has gone, but maps still not loading on live site.

    Will look at the duplicate API issue, but duplication was also there before the 1.9.1 upgrade and all plug-ins seem to co-exist then.

  8. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Yeah, it looks like there's a syntax error in the bgmpData.markers JSON array on your site. Working on it...

  9. magic_square
    Member
    Posted 1 year ago #

    Fantastic support Ian, I really appreciate it. Deactivating the other map plug-in hasn't changed anything.

  10. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    For some reason there are line breaks in the details value for each marker in the array:

    "details":"
    <p>Our Lady of Lourdes and St Michael Catholic Church<br \/>\nOsborne Road<br \/>\nUxbridge UB8 1UE<\/p>\n"

    ...when it should be

    "details":"<p>Our Lady of Lourdes and St Michael Catholic Church<br \/>\nOsborne Road<br \/>\nUxbridge UB8 1UE<\/p>\n"

    I'm having trouble reproducing it on my server, though, and there isn't really anything that changed from 1.8 that should affect that. Still looking into it...

  11. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    I've reverted the stable tag back to 1.8 until all of these issues are resolved. Once I figured out the line break issue, I'll post a new 1.9 release candidate for people to test on staging servers before releasing a stable 1.9.3 release.

  12. magic_square
    Member
    Posted 1 year ago #

    Thanks for such an honest response. Have reverted back to 1.8 and all is well.

    v1.9.2 looks ok on the staging server (although it should be noted the staging server is not a full replica of the live site - I'm still working on that. Let me know when you have a new version to test.

  13. OC2PS
    Member
    Posted 1 year ago #

    Same problem at http://www.csillamvilag.com/viszonteladok/

    I will revert back to 1.8

    Thanks for your hard work Ian.

  14. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Fixing this and releasing a stable 1.9 branch is still on my TODO list, but I've been pretty busy the past couple weeks, and it doesn't look like that's going to change soon.

    I'll eventually find time for it, but if anyone wants to help the process along, these two things would help a ton:

    1. Figure out how to reliably reproduce the bug that magic_square and OC2PS reported, where the line break in bgmpData.markers causes a fatal JavaScript error
    2. Write unit tests that expose the underlying condition that causes the bug, and tests any related code to ensure that condition is prevented and/or handled gracefully
  15. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    I've issued a new release candidate that hopefully fixes these bugs, but I'm still not able to reproduce them, so I'll need you guys to help test it out to make sure everything is good.

    You can download the new RC at http://downloads.wordpress.org/plugin/basic-google-maps-placemarks.1.9.3-rc1.zip

    If possible, install it on a staging server. That way your live site won't be harmed if there is still a bug, and also you'll be able to leave the error in place for me to inspect.

    I've also setup an email list to notify everyone when new RCs are available in the future. That way you'll have time to test it out on your staging server, and we can work out any bugs before the official release.

  16. majato
    Member
    Posted 1 year ago #

    Hi Ian,

    Thanks for the update. I've put it on my staging site and I'm still getting the same error (i.e. "loading map....")

    Here's an example page from the test site.
    http://images.norfolkplaces.com/indoor-soft-play/

  17. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Can you try changing line 1155 of core.php from...

    'details'	=> wpautop( $pp->post_content ),

    ...to

    'details'	=> $pp->post_content,

    ?

    I think that might be a clue.

    Also, could you edit the Hulabaloos Indoor Play placemark, switch to HTML mode, and then copy/paste the raw HTML into a pastebin.com entry? Then link to it here. That might help me reproduce the problem on my dev server.

  18. majato
    Member
    Posted 1 year ago #

    Hi Ian,

    Making the change on line 1155 of core.php seems to have worked - Thanks for your help!

    I'm not sure I follow regarding the placemark- if If edit the placemark in wordpress and view the html all I see if the text I added with a href link. Pretty sure this isn't what you need to help replicate it.

  19. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Hey majato, I'm glad (and, to be honest, kind of surprised) that that worked. That's not the final solution, since wpautop() is needed to convert line breaks in the post to paragraphs, but it's a clue.

    Would you be willing to send me the following things, so that I can try to recreate your environment locally and test different fixes?

    1. Backup of your database
    2. Copy of your theme
    3. List of active plugins
    4. Output from phpinfo()

    If you'd like to do that privately, you can e-mail them to ian@iandunn.name, or e-mail me a link to Dropbox, etc.

  20. magic_square
    Member
    Posted 1 year ago #

    Hi Ian,

    like majato, removing wpautop() worked for me on our staging server. All looks good now with 1.9.3 so have added it to the live site so you can see the result

    http://www.pilates4life.co.uk/courses/maps/

    hope this helps

  21. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Thanks for the report. I'm still not able to reproduce the bug, and a lot of users need wpautop() in order to keep paragraphs in their descriptions, so I can't just remove it.

    I'll have to keep working on it.

  22. tallpauluk
    Member
    Posted 1 year ago #

    We also have the same problem. http://www.gcrailway.co.uk/find-us/ I have tried the options above but to no avail.

    Thanks

  23. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    @tallpauluk, actually, it looks like your problem is unrelated to this. You've got some errors in your JavaScript console, and that's probably why the map won't load. Please start a separate thread for that.

  24. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    I've pushed a second release candidate that I'm hoping will fix this, but I'm not sure since I'm not able to reproduce the bug.

    Can you guys please test it out and let me know if it works or not?

  25. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    The release candidate for version 1.10 is out, and should fix this. Please let me know if any of you are still experiencing problems with it.

    http://wordpress.org/support/topic/bgmp-110-rc1-available

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.