WordPress.org

Ready to get started?Download WordPress

Forums

Basic Google Maps Placemarks
Just added full screen mode (3 posts)

  1. GPStracks.tv
    Member
    Posted 1 year ago #

    Hi Iandunn,

    Congratualations for the excellent work!

    I just added a piece of code to the plugin in order to be able to make it full screen as you can check at GPStracks.tv

    In case you are interested you can find the modified functions.js file at http://dl.dropbox.com/u/92513888/functions.js

    The edits are commented with the "GPStracks.tv" text for easier identification. The code is adapted from WP GPX Maps plugin, so a couple of images are used from it, in any case it is easy to replace those by your own. What is pending is to include tranlated text for the Maximize and Minimize buttons.

    Hope you consider including this functionality in your new release.

    Regards,
    Jorge

    http://wordpress.org/extend/plugins/basic-google-maps-placemarks/

  2. Ian Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    That's pretty cool, thanks for sharing that :)

    I'm personally a fan of plugins that do one thing really well, instead of getting bloated by trying to do everything, so I try to only include features that most people will use. I haven't heard anyone asking about full-screen support, so it's not a likely candidate for being included in future releases.

    At the same time, though, I think it's awesome when people customize and extend the plugin, and share that code with others. Since you posted the code here, anyone who wants to can copy it and set it up on their site too.

    One thing you might want to consider doing is putting your custom code in a separate JavaScript file in a functionality plugin. That way you'll still be able to upgrade to future versions of the plugin without overwriting your custom code.

    I think you could extend the bgmp object from another file just by doing something like,

    bgmp.addFullScreen = function()
    {
        // ...
    }

    You'd just need to make sure that you wait until after bgmp.init() fires.

    You might need a new hook inside buildMap() in order to call the function at the right time, but you might be able to do it from a separate file after the map loads.

    In version 1.9 there'll be a bgmp.map property, so that you can access it directly.

    If you attempt that and end up needing any hooks inside the core functions.js file, let me know and I'll add them to the next release.

  3. theshae
    Member
    Posted 1 year ago #

    What can I change to have the map maximized by default?

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.