WordPress.org

Ready to get started?Download WordPress

Forums

All in One SEO Pack
BUG REPORT: usage of manage_posts_columns and manage_posts_custom_colu (1 post)

  1. Darren Ethier (nerrad)
    Member
    Posted 3 years ago #

    Hey Michael,

    I'm the developer of Organize Series and I noticed what might be a bug with AIO SEO that only shows up in certain conditions.

    Organize Series hooks into the \edit.php?post_type=post page and also in the Quick Edit feature of that page. I noticed that when updating a post using the Quick Edit that the current row gets truncated and the column information for AIO SEO is eliminated.

    This will happen when any plugin hooks into the manage_posts_columns and manage_post_custom_column filter/action BEFORE AIO SEO (i.e. plugin custom columns appear prior to AIO SEO custom columns)

    The reason why this is happening is because AIO SEO executes those hooks and filters with the load-edit.php hook (in the addmycolumns() function. I tried editing AIO SEO and moving the manage_posts... action/filters outside of addmycolumns() and that fixed things.

    Instead of:

    add_action('load-edit.php','addmycolumns',1);
    
    function addmycolumns(){
    	$aioseop_options = get_option('aioseop_options');
    	$aiosp_posttypecolumns = $aioseop_options['aiosp_posttypecolumns'];
    //print_r($aiosp_posttypecolumns);
    
    	if ( !isset($_GET['post_type']) ) $post_type = 'post';
    		else    $post_type = $_GET['post_type'];
    
    		if(is_array($aiosp_posttypecolumns) && in_array($post_type,$aiosp_posttypecolumns)) {
    			if($post_type == 'page'){
    				add_action('manage_pages_custom_column', 'aioseop_mrt_pccolumn', 10, 2);
    				add_filter('manage_pages_columns', 'aioseop_mrt_pcolumns');
    
    			}else{
    				add_action('manage_posts_custom_column', 'aioseop_mrt_pccolumn', 10, 2);
    				add_filter('manage_posts_columns', 'aioseop_mrt_pcolumns');
    				}
    			}
    
    		}

    Do:

    add_action('manage_pages_custom_column', 'aioseop_mrt_pccolumn', 10, 2);
    add_filter('manage_pages_columns', 'aioseop_mrt_pcolumns');
    add_action('manage_posts_custom_column', 'aioseop_mrt_pccolumn', 10, 2);
    add_filter('manage_posts_columns', 'aioseop_mrt_pcolumns');

    The conditionals you have can be moved to the executing functions.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

  • RSS feed for this topic
  • Started 3 years ago by Darren Ethier (nerrad)
  • This topic is not resolved
  • WordPress version: 3.0.4