WordPress.org

1. DomenLo
   Member
   Posted 4 months ago #

   Howdy. I was toying around with this issue on one site, then noticed that after upgrading ag custom admin I had the same issue across all sites - when i upgraded to the new version the entire admin bar went missing.

   Absolutely no settings changed, just upgraded.

   Please help.

   http://wordpress.org/extend/plugins/ag-custom-admin/

2. DomenLo
   Member
   Posted 4 months ago #

   Can confirm that reverting two versions back (5.3 has a firephp include bug) "solves" the problem...

3. argonius
   Member
   Posted 4 months ago #

   You're right. In 1.2.5.4 version admin bar is hidden, because it does not have applied customizations like it's case in admin pages. This is new feature that would be implemented, but for now it's hidden because some users complained about this.

   If you want to enable it anyway, then follow these steps:

   Change:

   function print_page()
   	{
   		?><style type="text/css">
   		#wpadminbar{
   			display:none;
   		}
   		</style><?php
   	}

   to

   function print_page(){}

   on line 314 in ag-custom-admin/plugin.php

   Argonius

4. Sean
   Member
   Posted 4 months ago #

   Thank you, Argonius, for this fix! I really appreciate the support you provide for your plugin. It's a great plugin.

   I can understand why someone would want to hide the admin bar, but it's useful for my workflow to have the bar available.

   Here's one for ya: If they DO want the admin bar hidden, shouldn't you also add this override:

   * html body {
       margin-top: 0px !important;
   }

   because when the admin bar is hidden with plugin there is still a gray bar on the top of the screen.

   Thanks again!

5. bencahill
   Member
   Posted 3 months ago #

   @argonius

   Can you remove this 'functionality' in the next version? I love your plugin, but this is just ridiculous.

   I figured out the problem on my own, but was very dismayed to see that this is completely hardcoded—the action is added as part of the object construct, and there are no conditionals within the added function.

   If you do not fix this 'functionality' (or at least provide a checkbox to enable/disable), I will have to find another plugin to do this job. Hacking plugin code every upgrade is not cool.

   Thank you.

   P.S. For hiding the admin bar, this is a messy way to do it. You could also override the html margin-top as sean.norton noted, but that would ignore any html margin-top added by the user/theme. What you want to do is this:

   add_filter( 'show_admin_bar', '__return_false' );

6. DomenLo
   Member
   Posted 3 months ago #

   I would also really appreciate a fix for that. I had/have 70 sites that got an "upgrade surprise" and a whole lot of peeps who weren't really pleased "that I removed it" :)

   Have it hidden for people who have tweak settings there. And have it shown for people that just want to use it normally, pretty please :)

7. argonius
   Member
   Posted 3 months ago #

   It was just 'quick fix' for many people complaining about styles and asking to fix it or hide it. I didn't have much time to work on that and some critical problem cames up, and this became out of focus. I'm sorry for those problems you are experiencing, if you can, just fix it for now, next version should definitely be fine.

   Thank you all for your comments, this is all good for plugin improvement. Hope you would keep using AG Custom Admin and enjoy in future features.

   Thanks,
   Argonius

8. bencahill
   Member
   Posted 3 months ago #

   @argonius

   Sounds awesome. Thanks for the fast response. :)

Reply

You must log in to post.