WordPress.org

Ready to get started?Download WordPress

Forums

jQuery Pin It Button For Images
[resolved] Pin description in archive/index when "Always link to individual post page" (5 posts)

  1. brocheafoin
    Member
    Plugin Contributor

    Posted 12 months ago #

    Hey there,

    Love your plugin, very useful. Only issue for me is that when you use the experimental "Always link to individual post page" feature, the description sent to Pinterest when in an archive/index pages is the title or description of the archive page itself, not the title/description of the post itself.

    I modified you plugin to make it work in such cases and I'd like to submit a patch. How would I go about this?

    Thanks in advance,
    Alexandre

    http://wordpress.org/plugins/jquery-pin-it-button-for-images/

  2. mrsztuczkens
    Member
    Plugin Author

    Posted 12 months ago #

    Hi brocheafoin,

    sounds like a great job. I'm be happy to incorporate this change into the plugin.

    Right now the source code isn't stored on GitHub or anywhere else, so probably the only way you can do it is by sending to me the updated version of the code (I'm working on a pretty large code redesign, so I will have to apply it manually anyway). You can upload the code somewhere (e.g. Dropbox) and drop here the link to it.

    Also, if you possibly could point me to the places where you've added the changes, so I wouldn't have to diff through the previous version of the plugin, that would be much appreciated.

    Thanks!

  3. brocheafoin
    Member
    Plugin Contributor

    Posted 12 months ago #

    Hi mrsztuczkens,

    Here is my version of your plugin:
    https://dl.dropboxusercontent.com/u/14892002/code/jpibfi-brocheafoin.zip

    There is also a .diff file in the ZIP archive, which should help you spot my changes. It's diffed from http://plugins.svn.wordpress.org/jquery-pin-it-button-for-images/trunk @ revision 748840.

    Cheers!

  4. mrsztuczkens
    Member
    Plugin Author

    Posted 11 months ago #

    Hi again,

    I've incorporated your changes into the current version of the plugin. I have added a little change though - I don't add the additional jpibfi-data attribute if it's a singluar page/post being rendered at the moment (because there's no need for it).

    Thanks for your input.

  5. brocheafoin
    Member
    Plugin Contributor

    Posted 11 months ago #

    Cool!

    I agree with your change.

    Thanks for doing this, now I can keep updating your plugin. :-)

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.