WordPress.org

Ready to get started?Download WordPress

Forums

WooCommerce Correios
[resolved] Performance problem (13 posts)

  1. jribas2k14
    Member
    Posted 2 months ago #

    Hello,

    I took a look at your source code and I've seen a performance problem.

    For each Correios services you are doing a call to their webservice. It's not necessary, with only one unique call to their WS you can get all services quotations :)

    Regards, Jonathan.

    https://wordpress.org/plugins/woocommerce-correios/

  2. Claudio Sanches
    Member
    Plugin Author

    Posted 2 months ago #

    Send me a Pull Request with it in https://github.com/claudiosmweb/woocommerce-correios

  3. jribas2k14
    Member
    Posted 2 months ago #

    Claudio, I don't work with WordPress but if you would like to see how they do it in Magento, take a look here: https://github.com/willstorm/correios

  4. Claudio Sanches
    Member
    Plugin Author

    Posted 2 months ago #

    ?

  5. jribas2k14
    Member
    Posted 2 months ago #

    Claudio, I've just notified you about the problem. As I told you in my last message I don't develop in WordPress. I was just curious and took a look at your code and see this performance problem.

  6. Claudio Sanches
    Member
    Plugin Author

    Posted 2 months ago #

    Yes, I did it, I did not understand why you're showing me Magento's module that uses SOAP and how you could see it, but do not know PHP.

  7. jribas2k14
    Member
    Posted 2 months ago #

    Do I told you that I don't know PHP? I've told you that I don't work with WordPress ... I've just give you an exemple where they do one unique call.

    I was friendly telling you that you can get a better performance doing just one call. If you don't like to receive that kind of comments no problem.

    Good luck with your plugin.

  8. Claudio Sanches
    Member
    Plugin Author

    Posted 2 months ago #

    You are understanding me wrong xD
    I did not think anything bad, I'm even improving it now. And thank you for it.

    For me PHP is PHP, whether it's Magento or WordPress. It's just PHP.
    So I do not understand why you fear to help with the code and when you gave me something that uses SOAP totally different from how this plugin works, I seemed to me that you do not know PHP.

    When you started I was sure that you know PHP, so I asked to send at GitHub, so you helped me gain some time and we could discuss the code.
    Help is always welcome.

    I'm sorry, didn't mean to offend you.

  9. jribas2k14
    Member
    Posted 2 months ago #

    No problem Claudio.

    My intention was only to notify you. Unfortunately I don't have time at the moment to do a pull request.

  10. Claudio Sanches
    Member
    Plugin Author

    Posted 2 months ago #

    No problem, I'm sending this fix along with another that I needed to do.
    Thanks for the advice.

  11. jribas2k14
    Member
    Posted 2 months ago #

    Nice, well done :) The people who use your plugin will see the difference for sure.

  12. Claudio Sanches
    Member
    Plugin Author

    Posted 2 months ago #

  13. jribas2k14
    Member
    Posted 2 months ago #

    Seems to be ok Claudio :)

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.