Support » Plugin: Subscribe2 - Form, Email Subscribers & Newsletters » [PATCH] allow filtering of confirm url

Viewing 4 replies - 1 through 4 (of 4 total)
  • @diddledan,

    Nice patch and it does exactly what you describe, but why would another plugin or theme need to use such a filter? This approach gives easy access to alter actions, email hashes and IDs as well as the URL provided by the link. I have concerns that this enables access to core variables that really should not be altered.

    We can certainly apply a filter to the $link variable if that is needed as that still delivers the above. Can you provide more details?

    Thread Starter Dani Llewellyn

    (@diddledani)

    the specific issue I encountered is with an internal project that is somewhat monolithic, hence difficult to modify. It’s a search plugin that hooks http://example.com/?anything=anything and forces it into a search based on meta keys of the same name as the key in the GET request. The part of the patch which allows to utilise the admin-defined page as the target of the url is sufficient to alleviate my issue; I just felt that while I was there I might as well make it pluggable 🙂 feel free to discard the filter part – your suggestion that it exposes internal state is well made.

    @diddledan,

    Thanks for the explanation. I understand the need now so I’ll implement a filter on the $link variable in a future version for you.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘[PATCH] allow filtering of confirm url’ is closed to new replies.