WordPress.org

Ready to get started?Download WordPress

Forums

P2
[resolved] P2 Issues With WP 3.6-Beta1-24113 (6 posts)

  1. Kim Parsell
    Volunteer Moderator
    Posted 1 year ago #

    1. Front-end posting/editing - posting box drops below sidebar:

    Click Blog Post format for new post or Edit on existing blog post on main page, the editor box drops down below last item in sidebar. Add title, post content, tag, click Post It - post shows up but everything is still dropped down below last item in sidebar. Must refresh page to bring it back to the top. Editing a post in single view, the editor stays at the top where it should be. (Chrome, latest)

    It appears that the fix for this was supposed to be included in 1.4.2, didn't make it in (it was only changed on #postbox textarea#posttext, textarea.posttext in style.css):

    http://themes.trac.wordpress.org/browser/p2/1.4.2/style.css#L190
    http://themes.trac.wordpress.org/browser/p2/1.4.2/style.css#L235

    http://wordpress.org/support/topic/post-form-jumps-to-bottom-of-page-in-chrome?replies=13#post-4041792

    I applied the fix from line 172 to .inlineediting input[type="text"] (line 190) and #postbox input#posttitle, #postbox input#postcitation, (line 235) and the problem goes away.

    The P2 version 1.4.2-wpcom from the wordpress.com theme repo already has these changes to the stylesheet.

    This patch will fix the issue in the .org version: http://pastebin.com/aRRU8Abx

    2. Post format issues (supported):

    a. Blog post format:

    Error message on main page for blog post, single or multisite install, posted from front-end:

    Warning: Missing argument 2 for _post_formats_title() in E:\xampp\htdocs\xxxxx\wp-includes\post-formats.php on line 957

    This error appears after creating or editing a blog post format in /wp-admin/ and saving:

    Notice: Undefined variable: post_id in E:\xampp\htdocs\xxxxx\wp-includes\post-formats.php on line 958

    View post on single template, the errors are displayed twice.

    Edit a post in either view (main or single), save, and the error messages disappear, until page is refreshed.

    b. Link post format:

    Posted from front-end: link http://mydomain.dev/ displays as http mydomain dev and hyperlinked - the URL looks like it is displayed as a post title.

    Posted from /wp-admin/: link http://mydomain.dev/ displays as the post title Link Post Format and hyperlinked.

    c. Quote post format:

    Posted from front end: Quote and source show up correctly, styled properly.

    Posted from /wp-admin/: Title added (sets post URL). Quote source and link URL added, quote added in editor box. Only quote shows up in post, no source or link, doesn't use quote styling.

    d. Status Update post format:

    Posted from front end and from /wp-admin/: Status update displays correctly.

    Note: I realize that the purpose of P2 is to have the posting/editing done from the front-end, but there will always be a user who decides to post/edit something from /wp-admin/ instead. The results either way should be the same, correct?

    3. Post format issues (unsupported):

    Chat, audio, video, gallery and image post formats: These were all posted from /wp-admin/, and all have the same error message as the standard blog post format, appears twice in single post view:

    Warning: Missing argument 2 for _post_formats_title() in E:\xampp\htdocs\xxxxx\wp-includes\post-formats.php on line 957

    Edit a post in either view (main or single), save, and the error messages disappear, until page is refreshed.
    -----------------------------------------------------------------
    The post format issues show up in both version 1.4.2 from .org and version 1.4.2-wpcom.

    I know that post formats are still being finalized in core at the moment, but wanted to let you know of issues I've found so far when using P2 with 3.6 so you could start looking into fixes for them.

    If there are any questions or you need my help for further testing, just let me know. :)

  2. Scott Kingsley Clark
    Member
    Posted 1 year ago #

    This relates to the_title not having the Post ID sent to it. Looks like core should make that parameter optional just in case.

  3. Konstantin Kovshenin
    Member
    Posted 1 year ago #

    Re the missing argument notice, see: http://core.trac.wordpress.org/ticket/24011#comment:37

  4. Scott Kingsley Clark
    Member
    Posted 1 year ago #

    Great, thanks!

  5. Kim Parsell
    Volunteer Moderator
    Posted 1 year ago #

    @Konstantin: Thanks for the patch. :) I've tested it on my local install and can verify that the warning and notice messages are now gone on both existing posts and new posts. Hopefully the patch gets committed soon.

    This leaves item 1 (stylesheet fix, has patch) and the link/quote display issues (2.b and 2.c) to be resolved.

  6. Howdy Kim,

    Thanks for the great write up! :)

    We recently release 1.4.3 which has the stylesheet fix for item 1, as you pointed out.
    Today I also added styles for quotes and addressed the link issue for .com. Those changes should find their way back to .org soon, too.

    Again, thank you for putting the list together!

    Best,
    Konstantin

Topic Closed

This topic has been closed to new replies.

About this Theme

About this Topic