orderby issue: possible general solution

OK, more specifically I was thinking about this in the hicpo_pre_get_posts function:

if ( $active ) {
	if ( !$wp_query->get( 'orderby' ) ) {
		$wp_query->set( 'orderby', 'menu_order' );
	}
	if ( !$wp_query->get( 'order' ) ) {
		$wp_query->set( 'order', 'ASC' );
	}
}

Is there any chance you would check it at see if it works?

Hey Anriette,

Thanks for the feedback, now it’s working at least for the two of us. 🙂

I haven’t created a snipplet myself, but looking at yours made me wonder if the “playing safe” like if ( isset( $args ) ) ... part is necessary at all. I mean in theory.
Should $wp_query already contain what’s in $args at that point already?

I meant this question mainly for the original developer, what do you think hijiri?

Hi hijiri,

For the first look, it seems to be OK.
Thanks for the fix!

I’m curious though: should $wp_query already contain what’s in $args at the point of calling hooks for pre_get_posts? Is it triggered anywhere else then here?: wp-includes/query.php/get_posts()

Cheers

Hey mrseneca,

Does WP_Query('orderby=date&order=ASC') not work?

You mean: by default?
This was the first in my Google search result list:
https://wordpress.org/support/topic/sort-pages-by-date-in-admin-by-default?replies=4
Not the nicest with that global variable, but seems to be doing the job.