Glad that helped you. +1 for reading the FAQ! 🙂 As mentioned in the FAQ there’s nothing I can do about it until WP is updated.
Please suggest to the theme authors to read Workaround #1 in my FAQ for a possible solution for compatibility.
Thanks I have emailed them but I may have to hack it myself as the WPRT want the theme author to remove loads of current functionality if he submits a new version and this will certainly mess up some peoples sites so he is reluctant to do a new release.
Why they won’t ‘grandfather’ in some functionality in themes particularly as this one has over a million downloads is beyond me.
I definitely believe that modification of the menu admin is plugin territory, so can see wanting him to split his functions out into a Suffusion Plugin.
The suggestion in my workaround (wish I could take credit for the idea) has zero back-compatibility issues and can be implemented in a very small amount of time.
It does put people at risk for hitting the $_POST limit when modifying menus (the real reason this hook isn’t in core), but people are already at risk for that if their menus get too large anyway.
I wasn’t meaning menu functionality per se I was meaning other functionality built in to the theme that they want him to strip out which will break lots of sites and when I have 25+ built with this theme it will be a real challenge.
Well like the menu functionality, there is probably a lot of stuff that doesn’t belong in a theme. My opinion, fwiw, is that themes should be design/presentation-related only. But early on themes added a ton of functionality in the theme itself. If he ports all the functionality to a separate function (or maybe multiple plugins) it shouldn’t be overly painful, but I still don’t envy him the task. I think I will stick to plugins!
