The banner/modal won’t come up if there’s no active campaign. And as of today, there isn’t. Go to http://internetdefenseleague.org to see if there’s an active campaign at any given time. There should be another one in June when ACTA comes to voting.
I’ve tested in banner and modal mode and haven’t had any issues on my development site or my live site. I’ve switched it to banner mode and my site loads up fine: http://jazzsequence.com. However, it looks like something I added in the last update is keeping the scripts from loading.
I think I found the issue and I’m committing a fix. Should be up shortly.
Should be fixed in 1.0.2. Here’s what to look for to make sure it’s working: http://d.pr/i/6qi6
FOUND IT! Completely different thing than what I was looking at.
Okay, so, I’m assuming what you did was, download the plugin, activate, then went to the front of your site, right? E.g. you didn’t set what type of alert you wanted, you just went on about your business. The plugin loads the javascript relative to your selection on the admin page, like this:
function idl_signal_all_the_cats() {
$options = get_option( 'cat_signal' );
if ( !is_admin() ) {
if ( $options['type'] == 'banner' ) {
wp_enqueue_script( 'idf-banner', CAT_SIGNAL_PLUGIN_URL . 'js/banner.js', array(), '1.0', false );
} elseif ( $options['type'] == 'modal' ) {
wp_enqueue_script( 'idf-modal', CAT_SIGNAL_PLUGIN_URL . 'js/modal.js', array(), '1.0', false );
} else {
die();
}
}
}
The problem was that die() command which fires if there’s no option set. I’ve fixed it and it will be live shortly.
Thanks for the quick response, Chris. I’ve updated the plugin, but neither version seems to be appearing. I have to say that sometimes I can’t see recent changes in my sites, in spite of clearing out the browser history and cache. I think there is caching out there in the Net over which I have no control.
Neither is showing in either Firefox or Chrome.
Lane
I just installed the plugin on another site with a different theme, and still no joy.
Could it have anything to do with the themes being responsive? I used to be able to make themes do whatever I wanted, but the new jquery, etc. is still a mystery to me.
I’ve left the plugin active on both sites for now.
I’ve updated the plugin, but neither version seems to be appearing.
As I said (and as I added to the plugin description) if you’re not seeing the banner or the modal window that is expected when there is not an active campaign — which there isn’t. It won’t show up until the Internet Defense League initiates a protest at which time it will appear automatically. The issue I fixed was the page dying when you installed the plugin and didn’t set anything yet.
Both your sites are working as expected:
lanelester.com — http://d.pr/i/fzkh
the-web-doctor.com — http://d.pr/i/BhYd
Thanks, Chris. Pardon me for missing that point. I was testing another plugin that had campaigns, and I thought that point applied to it instead of yours.
Afterthought: It would be nice to have a Test option so we could immediately compare the Banner and Modal versions.
Lane
NP. It’s an easy thing to miss and since I wrote the plugin & knew what it was for, I completely forgot about the possibility that most people — knowing nothing about the IDL or not being on their mailing list — will probably activate the plugin and say “what gives? nothing happened!”
The cool thing IMO about the whole deal is that you leave this js on your site and then you don’t have to worry about it. When there’s a campaign it launches the alert automatically. The specific problem I needed to overcome in building the plugin was that if you added their javascript to your header.php it would get overwritten when you updated the theme (which is what happened to me), this makes it easier for WordPress users to set it and forget it.
Afterthought: It would be nice to have a Test option so we could immediately compare the Banner and Modal versions.
That’s all dependent upon the IDL and their framework. I agree, and, for that matter, if I want to black out my site year-round, I’d like the option to do it, but that comes down to what their script does and how it works which is something I have no control over. If they add an option to display the alert manually, then I will definitely update the plugin to accomodate. I think the main thing is that the campaigns are targeted for a specific bill as it moves to the House or from the House to the Senate, etc, and, as such, the actual banners are targeted for those bills/campaigns and wouldn’t necessarily be applicable other times.
I suppose I could add a ‘Test mode’ to the plugin that just pops up an “it works!” alert if the plugin is active and if the javascript is being loaded. Seems to me like it wouldn’t really serve the purpose it would be intended for since the actual banner is served by the Internet Defense League and not by the plugin itself.
Yes, there actually is an active campaign on CISPA right now, and yet there is no modal popup showing for said campaign. Which is the option I chose to use.
Edit: There is a cat signal on their main site right now about this, but there is no indication of how long the said signal is supposed to last.
Yes, there actually is an active campaign on CISPA right now, and yet there is no modal popup showing for said campaign. Which is the option I chose to use.
The campaign was for March 19. I know, because I got the email from them which is what prompted me to write the plugin in the first place. And on March 19, the modal and the banner were both active when selected, which is where the screenshots came from.
Hello, I’ve got the plugin installed at http://www.drew3000.net, there is a campaign on and it isn’t showing up. I did double check the settings and run the test. I tried the plugin after I couldn’t seem to get the script to work by pasting it into the theme. Do you know what could be up with that?
@drew3000
AFAIK there isn’t actually a campaign running right now. There was one on Monday but it was just on Monday. If you ran the test and it worked then it’s installed and ready for when there is a campaign.
http://www.drew3000.net/?_idl_test=1
Be great if they would throw up some test banners (messages) periodically. That would assure we are ready to go.
