WordPress.org

Ready to get started?Download WordPress

Forums

Image Source Control
Not working in 3.9.1 with theme newspaper (13 posts)

  1. funnyprinter
    Member
    Posted 3 months ago #

    Hi Thomas,

    Is it possible that the image source control plugin isn't working with 3.9.1? Or is it a problem with the newspaper v3.5 theme?

    thx. I really appreciate your help!

    https://wordpress.org/plugins/image-source-control-isc/

  2. Thomas Maier
    Member
    Plugin Author

    Posted 3 months ago #

    Hi funnyprinter,
    did you use ISC on another version and/or another theme before or did it never work for you?

  3. funnyprinter
    Member
    Posted 2 months ago #

    Hi Thomas,

    I tested it now on different servers with different themes. However it is somehow random than the source is shown or not and I cannot really find a pattern than it makes problems. Some findings:

    • sometimes only the first pictures gets a source
    • Random times other pics show a source too (not very often)
    • If the image has a caption ([caption]) or link the html structure is somehow sometimes destroyed (theme is working without plugin perfectly).
    • Sometimes it just helps to change something on a post and resave it?!

    On my private blog its pretty random, showing up once in a while. I cannot reproduce when the source is shown and than not?! http://www.manuelfink.de/blog/2014/test-image-src-control/ Also images with captions start growing to left out of the page.

    It seems that title images of themes (e.g. banners over the text) are not supported at all or?
    Nor I think images within page builder are supported?

    Do I need to resave old posts that the sources are added?

  4. funnyprinter
    Member
    Posted 2 months ago #

    Also it's not showing sources within the jetpack mosaic galerie.

  5. funnyprinter
    Member
    Posted 2 months ago #

    Hi Thomas,

    sorry for making 3 posts. Here I zipped 3 screenshots of one example were you see the problems with the html structure: http://www.manuelfink.de/upload/up/manu_20140602095656_JuSMqpBa_image_source_control_problems.zip
    The problem is that closing div tags get lost. I had to remove the content since I need to take the site online to do the research of my master thesis.
    the third screenshot was taken after I reduced the html markup to only img tags.

    Hope this helps fixing the bugs.

    Kind regards.

    Manuel

  6. Thomas Maier
    Member
    Plugin Author

    Posted 2 months ago #

    Hi Manuel,
    thank you for not only reporting this, but your effort in trying to find the source of the problem.

    I had a look at http://www.manuelfink.de/blog/2014/test-image-src-control/

    * the image is growing out of the post, because it is right floated. The ISC container inherits the align-parameter from the caption and you set it to "alignright". Remove this and it sould work.

    > It seems that title images of themes (e.g. banners over the text) are not supported at all or?
    > Nor I think images within page builder are supported?
    > Also it's not showing sources within the jetpack mosaic galerie.

    Right, the source caption is only possible for images with posts. There are just too many exceptions for other behaviour out there, but I welcome everyone who can support the one or another solution. The source code is publically visible on github too.

    > Do I need to resave old posts that the sources are added?

    No need to do that.

    Regarding the screenshots. I don’t really get the problem. If you like, you might explain in German ;)

  7. funnyprinter
    Member
    Posted 2 months ago #

    I think the problem was that I expected the plugin to appear on the post image.

    Does your module supply a method to get the source of an image? or better the html markup of the source of the post image?

    I found the part in the theme there it builds the post image html tag

    $buffy .= '<img width="' . $td_temp_image_url[1] . '" height="' . $td_temp_image_url[2] . '" itemprop="image" class="entry-thumb" src="' . $td_temp_image_url[0] . '" ' . $attachment_alt . $attachment_title . '/>';

    so my thought was to manually hook in here and add the isc html markup to show the source. Is there any simple way to do this?

  8. Thomas Maier
    Member
    Plugin Author

    Posted 2 months ago #

    I would be glad to add a hook where it makes sense, but where did you find this code? Its not from ISC.

    Edit: sorry, I overlooked "theme".

  9. Thomas Maier
    Member
    Plugin Author

    Posted 2 months ago #

    I think a function to query single image sources in templates is a good idea and I just added it to version 1.5. Maybe I will even be able to publish it today.

  10. Thomas Maier
    Member
    Plugin Author

    Posted 2 months ago #

    v. 1.5. is now online
    see the last point in the manual for the new frontend function I included: http://webgilde.com/en/image-source-control/image-sources-frontend/

  11. funnyprinter
    Member
    Posted 1 month ago #

    Hi Thomas, it seems to me that there is still a bug in isc. For me its wrapping 2 images into one wrapper. So
    isc_attachment_136 has attachment_136 a paragrahp and attachment_137 in it.
    See here: http://www.dailycat.de/warum-katzen-kartons-als-spielzeug-lieben-131/

  12. funnyprinter
    Member
    Posted 1 month ago #

    see above

  13. Thomas Maier
    Member
    Plugin Author

    Posted 1 month ago #

    this is tough to analyze, but I like your idea that was somehow not postet here:

    Another idea: instead of writing the text into a own span and positing this over the image an option would be to add the source to the caption of the image? Maybe with a trigger to decide where the source should be.

    Right now I have to figure out if the caption is extendable and how this would look like in the View-Editor. And still, the caption is just a shortcode and needs to be converted into frontend output. That is practically what ISC does as well.

Reply

You must log in to post.

About this Plugin

About this Topic

Tags