Thread Starter
Hassan
(@hassanhamm)
helga, to answer your question, this is my column header HTML code:
<th id="column-taxonomy" class="manage-column column-column-taxonomy sortable desc" style="" scope="col">
<a href="http://example.com/wp-admin/edit.php?post_type=car&orderby=Manufacturer&order=asc">
<span>Manufacturer</span>
<span class="sorting-indicator"></span>
</a>
</th>
My custom taxonomy is called (Manufacturer) and assigned to a custom post type (Car).
Ok, looks like Types is devtiating from the default. I have some code
function add_tax_columns( $columns ) {
/* keep trickery for post_tag and category' replacement until WP 3.5 */
switch ( $this->taxonomy ) {
case 'post_tag' :
$json = str_replace( "tags", "radio-{$this->taxonomy}" , json_encode($columns));
$columns = json_decode($json, true);
break;
case 'category' :
$json = str_replace( "categories", "radio-{$this->taxonomy}" , json_encode($columns));
$columns = json_decode($json, true);
break;
default:
$json = str_replace( "taxonomy-{$this->taxonomy}", "radio-{$this->taxonomy}" , json_encode($columns));
$columns = json_decode($json, true);
break;
}
return $columns;
}
in my plugin that looks through the columns and swaps out taxonomy-manufacturer for radio-manufacturer but it looks like it never finds taxonomy-manufacturer from the Types-generated code and so doesn’t get the radios right. Though, I’m confused by ozeanazul’s statement that quick edit is working.
I’m repairing my local testing environment and then I have a couple of projects to finish… then hopefully i can test Types.
Hi Helga,
I certainly will have a look into this once i’m past this deadline i have, since i truly appreciate the time you yourself have put into this. Just wanted to clarify one thing though; my quick edit is NOT working (in your post above you say your are confused that my quick edit IS working)—maybe that was a typo on your part?
So; the radio buttons show up in my quick edit, my my two/three options are:
– New York City
– California
– No location (an option that i assume is added by default for none)
The selection is always ‘No location’ in quick edit (even if New York City is actually selected if i open the post to look), and from the quick edit screen, i can change the selection, but it always reverts back to No location and doesn’t actually change anything.
As i mentioned though, i have a ton of plugins, maybe one of them is the culprit. I’ll troubleshoot in a few days and let you know.
My bad, someone said his quickedit worked. Shadowshapes, I think. I think you can import/export with Types. If so, could you export your post type and taxonomy so I don’t have to set up my own? And when you get to testing… check your console for Javascript errors and disable other plugins.
I think I found the bug. To help me double-check this, I’d appreciate if you could all download this version of RBfT and let me know if it solves the problem.
If so, I’ll push it live to the repo.
Assuming you’re still busy with your project, I went ahead and pushed it live anyway. Assuming no weirdness, it seems to work fine for me with Types taxonomies.
Hi Helga,
I just updated the plugin and i’m still experiencing the same issue.
I want to provide you with the info you requested above, but i’m so sorry, i don’t understand exactly from where you mean. Do you mean from the quick edit screen of the custom post type which i have assigned the taxonomies as radio buttons? Because on that screen i see no column headers where the taxonomies are listed.
But I’m assuming you mean somewhere else. Another edit page. But I’m not sure which/where?
Do you mean that you don’t have any quick-edit capability for your Types taxonomy? Or that you are getting checkboxes instead of radio buttons?
If you don’t have columns with the taxonomies, then you aren’t going to have quick-edit support.
Let’s start with a screenshot of your quickedit. I can confirm that this is working for my with Types.
Hi Helga. I do have access to the taxonomy on my quick edit page, and they do present as radio buttons—all good there. The problem is when i change the selection is the quick edit screen, they don’t save.
I wasn’t sure where you wanted me to explore with firebug, but attached are two screenshots from the quick edit page:
1) how my quick edit looks:
http://imgur.com/nWh57Uf
2) what firebug shows for where the taxonomy is on the quick edit page:
http://imgur.com/ezfo4xt
(i couldn’t see where to attach a screenshot here?)
You can’t attach a screenshot here. It’s a shortcoming of the site.
View post on imgur.com
Can you try disabling all other plugins. And possibly also revert to a default theme. So in your first screen shot, if you select “New York” and then update, you don’t see New York get saved? I’m at a loss, b/c this is definitely working now.
http://screencast-o-matic.com/watch/c2n3Y6n2Wi
This cast shows me changing the category on a post. As well as the ‘manufacturer’ taxonomy on a Types-generated ‘car’ type.
Hi Helga,
Yes, you understood correctly, i can change the radio taxonomy from quick edit, but it doesn’t save. It also always shows the none selected option (in my case ‘no studio’) in the quick edit screen, even if an actual option has been selected in the main edit screen.
I’m going to guess that it probably IS related to another plugin conflict.
I can’t change to a default theme just now, because even though i know that if all is okay, it shouldn’t be a problem to just do that and switch back (same with plugins), but this is my first wordpress site, and i created my own theme via the _s underscores theme, and i am chasing a deadline for next week, i want to quadruple check that nothing will mess up, before doing that.
Once I have time, I promise to revisit here, and post an update after process of elimination with the plugins, and maybe that will shed some light on it.
Meanwhile, in case it’s useful, here is a list of my active plugins:
http://imgur.com/1wFvEuo
I will do some investigating on my end as soon as I can 🙂
Well when you have more info let me know. Do check for script errors. F12 (web dev tools) in chrome and then click on the Console tab. Firefox also has a console. The selected radio button pulls the info from some hidden markup and then uses scripts to select the right button, so if scripts are broken it probably will fail.
Nothing jumps out at me among your plugins, but I’d try disabling them anyway. Also when changing themes, I’d recommend using Widget Saver. Or you can just make a full backup and restore to that.
I will do. (And thanks for recommending widget-saver!)
Hi, sorry for the delay!
My quick edit still work well with Types plugin (I show the radio buttons and it saved well to de Database on update).
Also, I updated to last version (1.6.1) but the Bulk actions still dont work. For the moment, to acheive it, I nedd to disable radio button for taxomomy (from the plugin options menu), do my bulk actions, and reactivate the radio buttons. It would be great if that can be works without requiring us to perform this workaround.
Thank you!
What bulk actions are you referring to? I have to admit to being really busy with other projects and not likely to be working too hard on this.
Everyone is free to fork me on github and send pull requests with updated features:
https://github.com/helgatheviking/radio-buttons-for-taxonomies
