WordPress.org

Ready to get started?Download WordPress

Forums

Nginx
[resolved] Nginx helper plugin not deleting sites from map.conf (2 posts)

  1. helms
    Member
    Posted 11 months ago #

    Hello,

    I'm using nginx helper plugin to update the map.conf file.

    When I add a new site, it updates the map.conf file w/out a problem. When I delete a site, it doesn't remove the entry from the map.conf file. Isn't it supposed to delete the entry?

    Thanks in advance.

    http://wordpress.org/extend/plugins/nginx-helper/

  2. rahul286
    Member
    Plugin Author

    Posted 11 months ago #

    I do not think we added codes to handle delete condition.

    To be honest, we missed it! But in a way its good NOT to handle this condition as:

    1. Any change in map.conf requires nginx service to be reloaded from command-line on server.
    2. Deleting a site but leaving map.conf line for it won't break nginx conf.
    3. On next site creation, map.conf will be regenerated without lines for deleted sites (if entries for them are deleted from wordpress site/blog tables)

    Still, if you wish to add a handler for delete condition, please feel free to do so.

    You may send a pull request of your changes at https://github.com/rtCamp/nginx-helper

    Please make sure you add a setting like "Regenerate map.conf when a blog is deleted" so that users have option to enable/disable this.

    If I missed anything here, please let me know.

Reply

You must log in to post.

About this Plugin

About this Topic