WordPress.org

Ready to get started?Download WordPress

Forums

Jetpack Lite
[resolved] new update crashed my site!! (45 posts)

  1. Samuel Aguilera
    Member
    Plugin Author

    Posted 7 months ago #

    @gaplauche you dont need to clear anything. the upgrade doesnt remove anything. the things @Piet is saying about this is not true. And anyway, this is not the topic of this thread.

    If you feel you have another problem, please open another thread with the proper information.

  2. Samuel Aguilera
    Member
    Plugin Author

    Posted 7 months ago #

    Well, these will be my last words in this resolved thread:

    1. The issue was reported for Jepack Lite 3.0. And is fixed after only 10 hours of the thread creation with the realease of 3.0.1. I have paid for famous plugins with a slower support.

    2. Obviously I make this plugin to work, not for breaking sites. And I test always on my own site (that at this moment is still running 3.0 withour break anything) and in many other sites where I can test it with different configurations (dedicated servers, shared hosting, differente PHP version...).

    3. I dont know nothing about your sites, I dont know your server configs, and you should know that the same code can run ok in thousand sites and not in others. If you only blame on me for the update but you dont give any info to me that can give some light about why is working on my sites and not in yours, then I cant do it anything for you.

    4. Jetpack Lite requires Jetpack because now it's only an addon for Jetpack (and was made clear in upgrade notice and many other places), but it doesn't matter if you have Jetpack installed or not before upgrading to Jetpack Lite 3.x. That fact will not cause any error.

    5. This plugin is published here under GPL2 license. This implies that the software is provided "AS IS" in the hope that it will be useful,but WITHOUT ANY WARRANTY. Everytime you installed a GPL plugin (even when paying) you're accepting this. If you don't like it simply don't use it. I'm giving to you free of charge and with my best wishes, and if you report a problem with respect and politely, giving me enough information to track it, I'll do my best, but if you're an impatient person that wants a fix a second after creating the thread and without giving me any helpful information, don't expect nothing more from me.

    I dont have any more to say about this. The issue affected only to a few people, and is resolved and confirmed by some of you, so there's nothing more to say from my part abou this issue.

  3. Piet
    Member
    Posted 7 months ago #

    @tschaplin - I have not tested it, but I think that if you have 2.3.4.1 of Jetpack Lite installed and you update to 3.0.1 WITHOUT installing the main Jetpack plugin, your site will not fall apart, BUT your stats will not work either.

    And that is what I meant with my additional comment about postponing a shitstorm: you didn't read the release notes before upgrading, I didn't either and among the users of the 40K+ downloads I think we can safely guesstimate that less than half of the users actually reads them. That is also the reason why I wonder why nothing was added to the upgrade notice, which is there specifically for this purpose...

    Without Jetpack installed the 3.0.1 version of Jetpack Lite does absolutely nothing. It does not break your site and neither does it track your site visits!

    So I expect that if there is no further update to this plugin, in a couple of weeks people will start wondering why their site stats don't update anymore. The reason for that is that Jetpack Lite without Jetpack does not do anything.

    @gaplauche - interesting, would you want to try that and post the results?

  4. Piet
    Member
    Posted 7 months ago #

    @Samuel - we posted at the same time.

    I am going to repeat what I lastly wrote and then the choice is yours.

    Without Jetpack installed the 3.0.1 version of Jetpack Lite does absolutely nothing. It does not break any sites and neither does it track any site visits!

    If you don't want to understand that, then that is your prerogative. It's your plugin, your choice, I think I have give you plenty of information to build in a failsafe for people that "overlook" the upgrade notice.

    By the way, can you point me on which line of the readme.txt of 3.0 I can find the upgrade notice?

    When I started reading your point 5, I thought what was coming was the line "you are welcome to fork my plugin and adapt it to your own wishes", instead I had to read the line that it comes without warranty and you're doing it for free and all.
    I'm sorry, but I find that a very lame excuse to hide behind. If you don't want the responsibility of dealing with potential plugin breakage then you should not release those plugins in the community, but instead keep them for yourself.

    Nobody told you to release the plugin, nobody forced you to do it free of charge, so please do not use that now as an excuse.

  5. tschaplin
    Member
    Posted 7 months ago #

    @Piet - I am afraid, but you are wrong; jetpack-lite 3.0.1 is doing what it is supposed to do, i.e. to switch off all jetpack modules except of the stats and short-URLs, so reducing the demanded system resources to a considerable extent. The difference to prior versions is that it is no longer standalone (which I admittedly would have preferred) but an addon to jetpack (curbing its hunger for CPU time etc).

  6. Piet
    Member
    Posted 7 months ago #

    @tschaplin, please read again.

    Without Jetpack installed the 3.0.1 version of Jetpack Lite does absolutely nothing. It does not break any sites and neither does it track any site visits!

    In the scenario that people do not read upgrade notices AND update to 3.0.1 the extension does not do anything.

  7. tschaplin
    Member
    Posted 7 months ago #

    @Piet - sure, an addon is in need of something to be added on - this is jetpack. And the users should properly be pointed to this change. But as I mentioned before, also in this connection jetpack-lite provides considerable (and measurable) benefits.

  8. jewpi
    Member
    Posted 7 months ago #

    I suggest the following code to check if Jetpack even exists and automatically activate if necessary, otherwise simply do nothing:

    if(file_exists(WP_PLUGIN_DIR.'/jetpack/jetpack.php')) {
       function check_if_active_jetpack() {
          $plugin = 'jetpack/jetpack.php';
          $active_plugins=wp_get_active_and_valid_plugins();
          if(is_multisite()) $active_plugins=array_merge($active_plugins,wp_get_active_network_plugins());
          if(!in_array(WP_PLUGIN_DIR.'/'.$plugin,$active_plugins)) {
            $current = get_option( 'active_plugins' );
            $plugin = plugin_basename( trim( $plugin ) );
    
            if ( !in_array( $plugin, $current ) ) {
              $current[] = $plugin;
              sort( $current );
              do_action( 'activate_plugin', trim( $plugin ) );
              update_option( 'active_plugins', $current );
              do_action( 'activate_' . trim( $plugin ) );
              do_action( 'activated_plugin', trim( $plugin) );
            }
          }
       }
       add_action('init','check_if_active_jetpack');
    
       function Leave_only_JetpackLite_modules ( $modules ) {
           $return = array();
           $return['stats'] = $modules['stats'];
           $return['shortlinks'] = $modules['shortlinks'];
           return $return;
       }
       add_filter( 'jetpack_get_available_modules', 'Leave_only_JetpackLite_modules' );
    
       function Activate_only_JetpackLite_modules() {
           return array( 'stats', 'shortlinks' );
       }
       add_filter( 'jetpack_get_default_modules', 'Activate_only_JetpackLite_modules' );
    }

    You may improve this with an admin warning message in case of missing Jetpack

  9. Piet
    Member
    Posted 7 months ago #

    @tschaplin - I understand that the new Jetpack Lite combination with Jetpack provides considerable benefits than having Jetpack standalone and disabling the lot manually.

    My concern however the following:

    1. fact is that at least half of the people in this thread installed the update without reading the upgrade notice (which I found at last unexpected at the bottom instead of the top of the upgrade notice list)
    2. fact is that if Jetpack is not installed (and it will not be installed if people don't read the upgrade notice), version 3.0.1 does not do anything

    Therefore my advice is to provide users with an informative message that

    • a. says that the new Jetpack Lite will not work without Jetpack
    • b. disables Jetpack Lite
    • c. (optional and only possible with earlier mentioned TGM Class) semi-automatically installs Jetpack.

    It is a pity that Samuel cannot seem to understand this, but as he said, it's GPL: https://github.com/senlin/so-jetpack-stats-only

  10. canofgg
    Member
    Posted 7 months ago #

    Piet, Thank you for your concise summary for the troubleshoot!
    I had the same issue (same issue on the latest WP). So I uninstalled Jetpack lite 3.0 and reinstalled one older version (2.3.4.1), which works just fine -that's all I need.
    I chose Jetpack Lite because I didn't like the weight of Jetpack (full version). So I don't see the point of having the Lite along with Jetpack full.

    Thanks!

  11. MarkRH
    Member
    Posted 7 months ago #

    FYI, I searched 3.8's code and the is_plugin_active() function is located in /wp-admin/includes/plugin.php around line 437:

    function is_plugin_active( $plugin ) {
    	return in_array( $plugin, (array) get_option( 'active_plugins', array() ) ) || is_plugin_active_for_network( $plugin );
    }

    So those of you that were (or still are) getting the error might check your code to see if it's actually there or not. If it is there, then something else is causing the error.

    Note, I had to do a manual upgrade of my blog to 3.8 as the internal update function was failing for me (my webserver wasn't talking very well to wordpress.org to get the update.. bad tracert or packetloss issue).

    I just got Jetpack and will try out the update. I noticed the code (zip file) for Jetpack is larger than WordPress 3.8 itself. Regardless of what I ultimately do, I do want to thank Samuel for his efforts with this plug-in.

  12. Piet
    Member
    Posted 7 months ago #

    Because Samuel has released a 3.0.2 version in the meantime with finally a notice inside the extension's code that notifies people of the new dependancy on the full Jetpack plugin, I have decided to fork his Jetpack Lite version 2.3.4.1 instead.

    Simple reason: I think there are many people that fancied Jetpack Lite because Jetpack itself didn't need to be installed.

    I have ripped out the shortlink as well as the widgets modules and renamed the plugin to SO Jetpack Stats Only which you can now find in the WordPress Plugins Repository as well as on Github.

  13. bizkit01
    Member
    Posted 7 months ago #

    This is ridiculous. I also had an issue with the upgrade completely killing my site, and now "Jetpack Lite" requires the full Jetpack plugin to be running - which the whole point of the plugin was to not have to have the full Jetpack installed.

    1 strike and you're out. Uninstall Jetpack Lite before it breaks your site, you can enable only Stats in the full Jetpack without having this guy's buggy code (and bad attitude) do it for you.

    Really, you run a raw "if ( ! is_plugin_active( 'jetpack/jetpack.php' ) )" and completely break a site if they didn't have Jetpack installed? (This was the code before the 3.0.1 update), and have the nerve to post "Your WordPress installation is your responsability not mine (SIC)" before the above code is found out? That's ridiculous.

  14. BankersWorstFear
    Member
    Posted 2 weeks ago #

    My site just has an error posted after upgrading jetpack:

    Warning: trim() expects parameter 1 to be string, array given in /home4/neomoney/public_html/banksworstfear.com/wp-includes/plugin.php on line 633

    line 633:
    $file = trim($file, '/');

  15. BankersWorstFear
    Member
    Posted 2 weeks ago #

    I fixed the problem by removing a plugin

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.