WordPress.org

Ready to get started?Download WordPress

Forums

[NEW] Notable - Social Bookmark/network plugin (53 posts)

  1. CalEvans
    Member
    Posted 8 years ago #

    Notable displays a series of icons below each post allowing your readers to easily submit you to many different social bookmarking and networking sites. (del.icio.us, digg, fark, etc.)

    This is the latest in my BlogBling series of plugins.

    Project Page

    As always questions and comments are always welcome.

  2. clarke1866
    Member
    Posted 8 years ago #

    You bastard! You stole all the ideas out of my head for wp-sociable and made it work. A backend menu that allows users to turn off and on the various sites, tooltips. Why?

    I am crushed. How I am supposed to go around and learn PHP one simple step at a time if you go and show me all the answers? Anyway nice work -- honestly. I wish you would have given me a heads up on your intentions, that would have been honourable.

  3. CalEvans
    Member
    Posted 8 years ago #

    Hi Clarke,

    Check the project page. I gave you credit for the icons there and in the code. I looked at your plugin and while it did work...well, I like taking things to the ridiculous extreme. :)

    I didn't think about notifying you. Sorry. No hard feelings. Feel free to pick it apart make it better. (God knows it could be better.)

    =C=

    p.s. I love your theme for K2. It's on my road map to implement that on my site.
    Cal Evans

  4. clarke1866
    Member
    Posted 8 years ago #

    Your plugin significantly improves on the idea and usability of the original, wp-sociable. Would you care to work together on its further development?

  5. CalEvans
    Member
    Posted 8 years ago #

    Clarke,

    The only thing I really want to add is an easier model to update the sites in the list. I've tried to break out the code so that I only have to add new code in a couple places but there's still too many. Actually, what I was thinking of was a separate XML file defining the sites. Then have my version checker code check for both a new version of the plugin and for a new version of the XML. If all that has changed is the site definitions then it could just download that and be done with it. (Sorry for the stream of consciousness, that's all off the top of my head)

    That having been said, I'm happy to work with you to implement any new features you'd like to see.

  6. CalEvans
    Member
    Posted 8 years ago #

    UPDATE:

    Thanks to CraigWD of http://www.googletutor.com who pointed out that the default path when you initially install the plug in is incorrect. if you have installed the plug in and are experiencing problems, make sure the image path is correct. On default installations, it should be:

    /wp-content/plugins/blogbling/images/

    I've updated the code and fixed another minor issue. The latest version is 1.1. You can download either the tar or the zip on the project page.

    http://www.calevans.com/view.php/page/notable

    =C=

  7. Chris_K
    Member
    Posted 8 years ago #

    This is very nice!

    Would you consider some minor tweaks so as to allow it to validate? For instance, in the icon urls, encode the "&" to be "&"? And I think the title attribs should maybe be enclosed in double quotes, but I didn't look too closely there.

  8. CalEvans
    Member
    Posted 8 years ago #

    @HandySolo,

    I don't understand about the &'s The only &'s that the code generates are in the & nbsp.

    I didn't realize there was a difference between single and double quotes. (My PHP is showing. :) ) I'll swap them out this evening and post a new version soon.

    =C=

  9. Chris_K
    Member
    Posted 8 years ago #

    Hmm, well I'm not php expert either :-) I was just looking at the resulting code and realized some of it wouldn't validate. I'll try and find those ampersands.

  10. Chris_K
    Member
    Posted 8 years ago #

    Well, I'm befuddled. You're writing out the &'s just fine.

    But, I used to validate. Now I don't: http://validator.w3.org/check?uri=http%3A%2F%2Fwww.solo-technology.com%2Fblog%2F

  11. CalEvans
    Member
    Posted 8 years ago #

    @HandySolo,

    Were you able to find out anything?

    =C=

  12. Chris_K
    Member
    Posted 8 years ago #

    Not much. If you look at my validation link above, that's all generated from running the plug-in. If I remove the line that displays the sociable list, I validate fine.

    Looks like the key bits are that all the attribute values of the links should be enclosed in double-quotes (url="..." title="..." etc.). That'd probably clear up most, if not all, of the validation issues.

    I was going to have a go at trying that in the plug-in, but it turns out that my php skills aren't quite up to it. :-\

  13. CalEvans
    Member
    Posted 8 years ago #

    @Handy
    I can't enclose the attributes of the URL in double quotes, it may break some of the services. I can, however, urlencode the urls before I put them in href. I've just packaged version 1.2, can you download it for me and try it out?

    Also, in 1.2 there's a new feature on the options page. you can select form several different spacers between the images including no space at all. This is for those people who have very narrow columns and the nbsp's were causing problems.

    Let me know if this one works better for you.

    =C=

  14. Chris_K
    Member
    Posted 8 years ago #

    Grabbed it and updated. Some improvements, but definitely still not validator friendly.

    Looking at the generated source, the del.icio.us tag looks fine:
    <a href="http://del.icio.us/post?url=http://www.solo-technology.com/blog/2006/02/23/google-page-creator/&amp;title=Google+Page+Creator" title="delicious:Google Page Creator"><img src="/blog/wp-content/plugins/blogbling/images/delicious.png" class="notable_bookmark" alt=":Google Page Creator" /></a>

    The & is a in there as &amp; and the validator doesn't seem to have issues.

    However, it just pitches a fit about the spurl tag:
    <a href="http://www.spurl.net/spurl.php?title=Google Page Creator&url=http://www.solo-technology.com/blog/2006/02/23/google-page-creator/" title="spurl:Google Page Creator"><img src="/blog/wp-content/plugins/blogbling/images/spurl.png" class="notable_bookmark" alt=":Google Page Creator" /></a>

    I wonder if that & between Creator and url should be &amp; instead?

    Here's a shortcut to validate one page.
    http://validator.w3.org/check?uri=http%3A%2F%2Fwww.solo-technology.com%2Fblog%2F2006%2F02%2F23%2Fgoogle-page-creator%2F

    I'm probably being anal about validation... but I was publically raked over the coals a month or so ago about it and now I'm perhaps "hyper aware"!

    And don't get me wrong -- I LOVE the plug-in and hope we can sort some of this out. If you'd prefer to take this to email or IM, just holler. handy.solo@gmail.com

  15. CalEvans
    Member
    Posted 8 years ago #

    @Handy,

    Just packaged v1.3. There was one difference between spurl and the others. I've changed it. See if that makes a diff for you.

    =C=

  16. Chris_K
    Member
    Posted 8 years ago #

    Alas, that might be a step backwards. Now the validation is unhappy with the del.icio.us tag and some other gunk.

    Specifically here:

    <a href="http://del.icio.us/post?url=http%3A%2F%2Fwww.solo-technology.com%2Fblog%2F2006%2F02%2F23%2Fgoogle-page-creator%2F&title=Google+Page+Creator" title="delicious:Google Page Creator">

    Before the title attribute, there's a & buried in the previous string that I suspect is crying out to be a &amp; (like it was in 1.2!).

  17. CalEvans
    Member
    Posted 8 years ago #

    @handy,

    But that's a valid seperator. I can't change that or the service we are calling won't accept it. :S The & in question is seperating the key=value pairs of url and title. The only way to do that is with a &. Let me try putting an &amp in there and see if it blows chow on my site.

    =C=

  18. Chris_K
    Member
    Posted 8 years ago #

    Yep, & is very valid. But, my understand only..., if you want to validate xhtml you put it in the url as a &amp;.

    Ok here, this link explains more concisely than I do: http://www.htmlhelp.com/tools/validator/problems.html#amp

  19. CalEvans
    Member
    Posted 8 years ago #

    @Handy,

    Ok, grab 1.4 and test that.

    =C=

  20. Chris_K
    Member
    Posted 8 years ago #

    Bingo!

    It validates perfectly now :-) Of course, last time I fixed an ASP app to validate, it no longer worked... ;-) I'll test 'em a bit now, but looking good.

    Thanks for your time on this -- hope I wasn't too much of a p.i.t.a.

  21. CalEvans
    Member
    Posted 8 years ago #

    @Handy,
    [soapbox]For the record what that URL describes, while perfectly valid is a problem with old browsers. It's disingenuous if the html validator you are using is spitting out those simply because it doesn't LIKE the code. Valid HTML isn't a subjective thing and putting a & in a url is valid according to all the docs I've read.[/soapbox]

    That having been said, I'm always looking to make my code better and don't want to cause anyone any problems with their site so I'm happy to continue to hunt this issue till we squash it. :)

    =C=

  22. CalEvans
    Member
    Posted 8 years ago #

    @Handy,

    Followup: Users are never a PITA. :)

    =C=

  23. barrow
    Member
    Posted 8 years ago #

    Love the plugin, but I have another issue that hasn't been discussed. The prepending of the tooltips works great in Firefox, but in IE when you mousover you only get ":POST_TITLE" instead of "digg:POST_TITLE".

    Will yu be supporting IE?

    Thanks,
    Jason

  24. CalEvans
    Member
    Posted 8 years ago #

    Jason,

    Just released version 1.5. Tooltips now work in IE. Thanks for pointing this out to me.

    Cade can be downlaoded form the Project Page.

  25. barrow
    Member
    Posted 8 years ago #

    Awesome, just upgraded and I can confirm that the tooltips are working in IE. Perfect!

  26. ack
    Member
    Posted 8 years ago #

    Great plugin. I am though getting an error on the Options page, and need to figure out if it's due to me changing the directory location or the fact that my install is in a sub-directory. It's in the version check part, so doesn't seem to be impacting much.

    Fatal error: Call to undefined function: val() in ...wp-notable.php on line 191

  27. CalEvans
    Member
    Posted 8 years ago #

    @ack,

    Fixed. 1.9 is now available. Cna you confirm that it fixes your problem?

    =C=

  28. domfos
    Member
    Posted 8 years ago #

    I just installed this and get the following error:

    Fatal error: Call to undefined function: register_activation_hook() in websitehostingiq.net/wp-content/plugins/blogbling/wp-notable.php on line 384

    Any ideas.
    I'm on WP 1.5.2

  29. CalEvans
    Member
    Posted 8 years ago #

    @domfos,

    Hmmmmm...I'm betting that's a 2.0 function. I'll work on it tonight and release a version that should work with 1.5.x

    =C=

  30. CalEvans
    Member
    Posted 8 years ago #

    @domfos,

    Ok, I changed things around a bit and it should be compatible with 1.5 now without losing any functionality.

    Can you download a copy of 1.10 from the project page and tell me if it works?

    =C=

Topic Closed

This topic has been closed to new replies.

About this Topic