WordPress.org

Ready to get started?Download WordPress

Forums

[resolved] Need direction to this code location (14 posts)

  1. Will Taft
    Member
    Posted 7 years ago #

    I am trying to take advice and fix some validation errors. I ran a page and got results.
    http://validator.w3.org/check?uri=http%3A%2F%2Fwilltaft.com%2Fwordpress%2Feducation%2Fhomeschool%2Fhomeschooling-and-socialization%2F&charset=%28detect+automatically%29&doctype=Inline&ss=1

    I pretty much understand the error explanations and can see the errors in the numbered source lines, but don't know where to find the actual files to fix.

    For example I could fix error #1, but the only theme files I can locate are the .php files and none of them have that code in them. I did a keyword search through all the php files and the source code that is flagged as being in error is not found.

    I thought I read somewhere that pages like the page I validated are generated dynamically? Is that my problem?

    I think I could fix these errors if I could find the code that needs fixing!

    Thanks!

  2. Will Taft
    Member
    Posted 7 years ago #

    Maybe my original question is so dense, it's comic.... But, where do I find the code to fix after running a url for a WP page through a validator? I can't find the specific errors anywhere in the php files.

  3. Andrew Ozz
    WordPress Dev
    Posted 7 years ago #

    In xhtml you have to use "self closing tags" meaning <br> is wrong, <br /> is correct, <img> - wrong, `<img /> - correct, etc. It looks like the theme you are using doesn't follow the standard.

    The code is generated dynamically mainly by the php scripts in your theme: index.php, header.php, sidebar.php, page.php, footer.php, etc. Look in there to find and fix the chunks of html between the php (don't touch anything that's inside the <?php ... ?>). It helps if you have a text editor that highlights the content by type.

  4. Will Taft
    Member
    Posted 7 years ago #

    Yes, I thought the errors were in places that I did not mess with. Two of them are actually in the code that Google generates for you to insert a Google Reader feed button on your site.

    All I am trying to do is figure out why this page:

    http://willtaft.com/wordpress/education/homeschool/homeschooling-and-socialization/

    won't load the sidebar correctly in IE. I figured if I started by fixing any validation errors, that would be best.

    As you say to do, the php files were the first place I looked to fix the errors. However, for the first error, I can not find, even with full text searching, any of the code referred to around lines 125 and 130. Am I approaching this incorrectly?

  5. Andrew Ozz
    WordPress Dev
    Posted 7 years ago #

    The first error is in the sidebar.php where it lists categories:

    <div class="bloque2">
    <h3>Categories</h3>
    <ul>

    You have opening <ul> tag, then some php and you missing the closing </ul> tag just before the </div> tag.

  6. Will Taft
    Member
    Posted 7 years ago #

    Thank you, that was easily fixed. But what I need to be able to do is what you did. How did you know from looking at the validation report that the missing tag was in the sidebar file? For some reason, I was unable to see that?

    As a side note, fixing this error did NOT fix the sidebar dropping to the bottom in IE.

  7. Kernkraft
    Member
    Posted 7 years ago #

    Yeah I'm also having tons of issues with IE ... my footer appears next to my sidebar pushing the body all the way to the left...

    The way I found my sidebar errors was because it mentioned column 3... column 3 when I open up my page in IE just happens to be the sidebar.

    I'm down to 23 errors from 47 though... and I still can't get my body's, sidebar's and footer's background to appear and my footer to appear well where a footer should.

  8. Will Taft
    Member
    Posted 7 years ago #

    Well, I am down to three errors, but my sidebar is still on the bottom. Hopefully azaozz will be back to answer my question in my last post, because that is my big problem.

    I did just find, and hopefully fix, the error listed for line 199, a missing </div>. I found it though, by doing a full text search of all my php files one by one until I found the referenced text. Not the best way to find errors, I am sure!

    I am now down to two errors. I found one of the two, the one on line 167 in my sidebar file within the code Google supplied for my Google Reader button. I can not seem to fix it, no matter what I try. I don't completely understand the error description.

    And my last error on line 149, I have not a clue what to do with that! Can you translate it for me?

  9. Will Taft
    Member
    Posted 7 years ago #

    And now I find that one of the errors I thought I fixed, does not work. The error listed for line 199, is a missing </div>. If I add the missing tag, the validator says it is fixed. But when I view the page, it is completely dark. If I remove the fix, the page is viewable again! I wonder what's up with that?

  10. Will Taft
    Member
    Posted 7 years ago #

    Can someone please look at this error and the code that is wrong? The code is in the WP Paste bin, link at end of this post. I do not understand the error or how to fix it. Thanks!

    Error Line 149, column 25: required attribute "action" not specified .

    <form name="subsform">

    The attribute given above is required for an element that you've used, but you have omitted it. For instance, in most HTML and XHTML document types the "type" attribute is required on the "script" element and the "alt" attribute is required for the "img" element.

    Typical values for type are type="text/css" for <style> and type="text/javascript" for <script>.

    http://pastebin.ca/421280

  11. Will Taft
    Member
    Posted 7 years ago #

    Every page on my WP site now validates except for the single post page. http://xrl.us/vkjd To make validation perfect, I can fix the missing </div>, but no matter where I insert it, the entire site then goes dark and unreadable.

    I can leave the </div> missing and the site is fine. But as I am ultimately trying to fix the fact that, in IE, my sidebar drops down on this page, I'd like it to validate and work before attacking the sidebar issue further.

    I am thinking that it might have to do with the code:

    <div class="cnt">

    The single post page is the only one that calls from the header file to the .cnt part of the css file. I put the css file in the paste bin:

    http://wordpress.pastebin.ca/421669

    Can anyone help with this last issue?

    Thanks.

  12. Andrew Ozz
    WordPress Dev
    Posted 7 years ago #

    WT, you have to add the missing </div> in the footer, just before the </body> I think.

    To answer your previous question: each page in WP is build by several "blocks" the header, the sidebar, the main page (usually in the index.php), the footer. Additionally there are a few main templates that are used for different types of pages: home.php, single.php, search.php, etc. You can pretty much make the boundaries between these blocks out by the css codes (for example the sidebar starts at <div class="sidebar">, etc.)

    When you look at the source of the displayed page, notice exactly what is displayed, then try finding it or the code before/after in the templates.

    If you want to see more, install FF + the web developer plugin - gives tons of info...

    Kernkraft, perhaps you can contact your theme's author to see if there are fixes?

  13. Will Taft
    Member
    Posted 7 years ago #

    azaozz - You got it perfectly! That is seems to be exactly where the missing </div> needed to go. I will examine the source on that page closely tomorrow to see if I can figure out what you saw to know that. Thank you VERY much.

    This all started because my sidebar drops to the bottom on that page in IE. (Fine in Firefox). I was trying to fix that and was told that I should get all validation errors fixed first to see if that fixed the sidebar issue. It did not as you can see if you visit this link in IE.

    http://xrl.us/vkoq

    Do you have any idea why the sidebar might be dropped down when viewing that page in IE?

  14. Will Taft
    Member
    Posted 7 years ago #

    Unfortunately, it only seemed to work for a while??? Now when I view this page linked above, that page is too dark to read. Just like what happened when I put it at the end of the header page. It worked fine the first few times I visited it after putting in the </div> on the footer page, now it's bad again. What the......? So I took the </div> out. It does not seem to relate to my real problem which I need to fix which is getting the sidebar in the correct location on that one page when viewed in IE.

    This was a free theme and is the 25th most downloaded WP theme. The theme's author is busy with other things now, so no support.

Topic Closed

This topic has been closed to new replies.

About this Topic

Tags

No tags yet.