WordPress.org

Ready to get started?Download WordPress

Forums

More Smilies Plugin Modification Needed (23 posts)

  1. intricateartist
    Member
    Posted 7 years ago #

    The More Smilies 2.1 plugin breaks the paragraph formatting in comments. Since Matt is no longer supporting his plugin (I've emailed him for paid plugin support, but haven't heard back yet), I wondered if anyone could have a look at the guts of it and tell me what needs to happen to keep it from breaking the formatting.

    I know a lot of people use this plugin, so a fix would be really beneficial to a lot of users.

    Thanks in advance!

  2. intricateartist
    Member
    Posted 7 years ago #

    anyone have any ideas?

  3. whooami
    Member
    Posted 7 years ago #

    define "breaks the paragraph formatting"

    Be specific.

  4. intricateartist
    Member
    Posted 7 years ago #

    The paragraph line break formatting is stripped. There are discussions elsewhere in the forums on this happening with other plugins, with specific solutions for those plugins but nothing yet for the more smilies plugin.

    Here's a good description of it on this thread:
    http://wordpress.org/support/topic/118068?replies=12

    Here's another plugin that created the same problem with a resolution:
    http://wordpress.org/support/topic/73723?replies=19

    Thanks for your help!

  5. Dgold
    Member
    Posted 7 years ago #

    I would also like this plugin to be fixed. I was just going to try this plugin, after upgrading to 2.2, but I've found out from a couple threads here that it is broken. I also noticed another emoticon plugin that was broken in 2.2, if I find the link again I will add it here.

  6. whooami
    Member
    Posted 7 years ago #

    Im willing to take a look but I think I need a place to download the zip from :P I dont see a download link on Matt's permalink page

  7. Dgold
    Member
    Posted 7 years ago #

    matt is playing with another blogging platform and isn't even doing his site in WP right now

    try
    http://wordpress.org/extend/plugins/more-smilies/#post-195

  8. whooami
    Member
    Posted 7 years ago #

    I was just coming back to say I found it, thanks :)

  9. whooami
    Member
    Posted 7 years ago #

    dgold, I notice in that other thread intricateartist mentions some filters. Ive installed 2.1 and looked through the code and I dont see any filters anywhere in the source.

    What version are you using, is it higher than 2.1?

    I'm seeing some errors, some pretty big errors, but the linebreaks are staying intact for me.

    if youre using a version above 2.1 can you email me a copy of your zip -- feel free to use the email addy that I used when I sent off the thank you for the donation :)

    I emailed you to see if you happen to be awake and have msn messenger or something equivalent.

  10. intricateartist
    Member
    Posted 7 years ago #

    I've got 2.1 installed, the filters are toward the top of the code in the plugin here:

    # remove filters
    		remove_filter('comment_text', 'convert_smilies', 20);
    		remove_filter('the_content', 'convert_smilies');
    		remove_filter('the_excerpt', 'convert_smilies');
    
    		# add filters
    		add_filter('comment_text', array(&$this, 'convert_smilies'));
    		add_filter('the_content', array(&$this, 'convert_smilies'));
    		add_filter('the_excerpt', array(&$this, 'convert_smilies'));

    Here's what it's doing to my comments, note the bold commentors name I'm responding to should be on a new line:
    http://intricateart.com/blog/archives/2007/05/26/final-scan-titto-preening/#comment-264255

  11. whooami
    Member
    Posted 7 years ago #

    I'm going to show you what I get on my FRESH 2.2 install with NO other plugins activated. The only change I have made was to one line in the WordPress core that **might** be affecting this - and I didnt make the change for that reason, I made it because it was causing me another error.

    Take a look at this:

    http://www.village-idiot.org/broke/test.gif

    the top is what I typed -- the bottom is what is displayed.

    The source contains the necessary after the dizzy smilie.

  12. whooami
    Member
    Posted 7 years ago #

    intricateartist,

    you are NOT using the same plugin source that I am.

    What you pasted is NOT present in any of the files that I am using.

    if you would like to verify that, grab he plugin I am looking at from here:

    http://wordpress.org/extend/plugins/more-smilies/#post-195

    You can, also, if you like zip up whatever it is that you are using, and e-mail it off to me @ whoo AT village-idiot DOT org

    Additionally, you can also look at the plugin code here:

    http://pastebin.4programmers.net/2278

  13. intricateartist
    Member
    Posted 7 years ago #

    Your test comment dropped into moderation, but I released it so you can see what happened to the formatting.

    I disable just the more smilies plugin, and the formatting returns to normal, so I don't think it's related to other plugins.

    I can't see the change you made in your source - it's displaying characters only. :/

    Thank you so much for your help!

  14. whooami
    Member
    Posted 7 years ago #

    I saw what it did in the preview.

    You're not paying attention to the important details -- you are NOT using the same plugin source that I am. I don't know where you got your plugin, but what I am using doesn't replicate the problem that you are seeing.

    And you wont see the change I made because I made it to a file inside the wp-includes/ dir. Im not sharing it because I havent determined tha it solves anything -- since we arent using the same source code.

  15. intricateartist
    Member
    Posted 7 years ago #

    I'm not sure how that happened, I just deleted all those plugin files in my version 2.1 and replaced them with the files in the same version that you grabbed, they are indeed completely different, and are now presenting a whole different problem.

    Exclamation point smiley gifs are everywhere - I'm guessing I need to rewrite my smiley config file for my personal set?

  16. whooami
    Member
    Posted 7 years ago #

    I dont have any clue what you need to do since I dont know what you were using. The only error I got was preg_replace error and that occurred after I decided to change smilies from one set to another. THAT was the error I fixed.

    I'll keep an eye on this thread to see if dgold can lend any insight into what his specific problem is.

  17. intricateartist
    Member
    Posted 7 years ago #

    I am using the same plugin that you downloaded now, and the new errors I'm getting are most obvious here:

    http://intricateart.com/blog/archives/2007/05/25/a-new-dyson/

    The smilies are replacing words and parts of words, regardless of the :smiley: colon command. Even when I use the default smiley set, the exclamation.gif replaces the exclamation point throughout my posts. There's also added text in front of and trailing the smileys:

    : cheerful y" /> :

    Any ideas?

  18. intricateartist
    Member
    Posted 7 years ago #

    I wound up dumping More Smilies and replacing it with Custom Smileys:

    http://qad.donationcoders.com/wp/custom-smileys

    It works perfectly with 2.2, it's even easier to add and configure new smileys.

  19. whooami
    Member
    Posted 7 years ago #

    intricateartist,

    glad you got it sorted -- I *probably* could have provided you the fix for that, but since you found something that works better ... :)

  20. intricateartist
    Member
    Posted 7 years ago #

    I wonder if I should leave this open for others? It's not technically resolved - there are others who are looking for this fix.

  21. whooami
    Member
    Posted 7 years ago #

    it doesnt matter, leave it open, leave it closed :)

  22. Dgold
    Member
    Posted 7 years ago #

    I checked out both plugins tonight and concluded that Custom Smileys works great. Since More Smilies author isn't using WordPress anymore, and I noticed Custom Smileys author has been upgrading regularly and has plans to upgrade her plugin again soon --- I think the best plan is use Custom Smileys.

    Now, if someone wants to fix More Smilies and re-release it, I'm sure some people would appreciate that. But I think I'm all set with Custom Smileys for my emoticon needs.

    Thanks for the thread all involved 8-)

  23. whooami
    Member
    Posted 7 years ago #

    fixing it isnt the issue yet -- since Ive yet to determine that it's broke :P

    good luck with whatever you use :)

Topic Closed

This topic has been closed to new replies.

About this Topic