More errors in debug mode

  • Resolved Jacob N. Breetvelt

    (@opajaap)


    10 years, 7 months ago

    Saving a post produces:

    Notice: Undefined index: gmap_gpx_map_switch in /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-content/plugins/google-maps-gpx-viewer/php/map_functions.php on line 215 Notice: Undefined index: gmap_gpx_marker_switch in /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-content/plugins/google-maps-gpx-viewer/php/map_functions.php on line 227 Notice: Undefined index: gmap_gpx_map_switch in /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-content/plugins/google-maps-gpx-viewer/php/map_functions.php on line 215 Notice: Undefined index: gmap_gpx_marker_switch in /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-content/plugins/google-maps-gpx-viewer/php/map_functions.php on line 227 Warning: Cannot modify header information – headers already sent by (output started at /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-content/plugins/google-maps-gpx-viewer/php/map_functions.php:215) in /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-admin/post.php on line 222 Warning: Cannot modify header information – headers already sent by (output started at /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-content/plugins/google-maps-gpx-viewer/php/map_functions.php:215) in /mnt/webf/d1/15/51893315/htdocs/opajaap/test/wordpress/wp-includes/pluggable.php on line 875

    http://wordpress.org/plugins/google-maps-gpx-viewer/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter Jacob N. Breetvelt

    (@opajaap)

    10 years, 7 months ago

    I changed the function gmap_gpx_save_postdata( $post_id ) in file map_functions.php to: ( see the left tabbed lines ).

    function gmap_gpx_save_postdata( $post_id ) {
		if ( 'page' == $_REQUEST['post_type'] ) {
			if ( ! current_user_can( 'edit_page', $post_id ) )
				return;
		} else {
			if ( ! current_user_can( 'edit_post', $post_id ) )
				return;
		}
		if ( ! isset( $_POST['gmap_gpx_noncename'] ) || ! wp_verify_nonce( $_POST['gmap_gpx_noncename'], plugin_basename( __FILE__ ) ) )
			return;
		$post_ID = $_POST['post_ID'];
	$mydata =  isset($_POST['gmap_gpx_map_switch']) ? $_POST['gmap_gpx_map_switch'] : '';
		add_post_meta($post_ID, 'gmap_gpx_map_switch', $mydata, true) or
		update_post_meta($post_ID, 'gmap_gpx_map_switch', $mydata);

	$mydata =  isset($_POST['gmap_gpx_map_title']) ? sanitize_text_field( $_POST['gmap_gpx_map_title']) : '';
		add_post_meta($post_ID, 'gmap_gpx_map_title', $mydata, true) or
		update_post_meta($post_ID, 'gmap_gpx_map_title', $mydata);

	$mydata =  isset($_POST['gmap_gpx_map_height']) ? sanitize_text_field( $_POST['gmap_gpx_map_height']) : '';
		add_post_meta($post_ID, 'gmap_gpx_map_height', $mydata, true) or
		update_post_meta($post_ID, 'gmap_gpx_map_height', $mydata);

	$mydata =  isset($_POST['gmap_gpx_marker_switch']) ? $_POST['gmap_gpx_marker_switch'] : '';
		add_post_meta($post_ID, 'gmap_gpx_marker_switch', $mydata, true) or
		update_post_meta($post_ID, 'gmap_gpx_marker_switch', $mydata);

	}

    It’s a matter of education to initialize your vars…

    This piece of code also generates an error:

    if ( 'page' == $_REQUEST['post_type'] ) {
			if ( ! current_user_can( 'edit_page', $post_id ) )
				return;
		} else {
			if ( ! current_user_can( 'edit_post', $post_id ) )
				return;
		}

    and can be simplified to:

    if ( ! current_user_can( 'edit_page', $post_id ) ) return;

    Did you hurry to release this???

    Plugin Author Bernd Altmeier

    (@bernd-altmeier)

    10 years, 7 months ago

    Thanks for your work. The Code was from the wordpress-plugin-developer-doc page and I didn’t test it in debug mode

    Should be solved in 3.4

    Thread Starter Jacob N. Breetvelt

    (@opajaap)

    10 years, 7 months ago

    Thank you!

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘More errors in debug mode’ is closed to new replies.