WordPress.org

Ready to get started?Download WordPress

Forums

[resolved] Menu label issue in WP3.3 upgrade (42 posts)

  1. spinlessplates
    Member
    Posted 2 years ago #

    I have upgraded to WP3.3 and all my menu labels have reverted to the titles of my pages.
    I had overwritten these using all in one seo pack but the new WP upgrade appears to have disabled this function somehow.
    Anyone have any ideas how I can reactivate this function in all in one seo pack or turn off the issue in WP3.3
    Thanks

  2. Tim S
    Member
    Posted 2 years ago #

    The plugin may not yet be compatible with 3.3 yet.

  3. spinlessplates
    Member
    Posted 2 years ago #

    Thanks for the reply Tim. Says compatible to 3.3 and has been updated in last couple of days. Also appears that some users using page menu editor plugin has had similar problems since 3.3 upgrade. Would you have any ideas what the issue could be?

  4. Tim S
    Member
    Posted 2 years ago #

    When I looked at the plugins page, it's lists 3.3 but only one person voted on its compatibility and said it didn't work. Without actually exploring the plugins code, I'm not much help. I'd see if you can leave forum post on his plugin forum:

    http://semperfiwebdesign.com/forum/

  5. ireneu
    Member
    Posted 2 years ago #

    menu label broken in my installation too

  6. Michael Torbert
    WordPress Virtuoso
    Posted 2 years ago #

    Hi guys, I'm looking into this right now.

  7. Michael Torbert
    WordPress Virtuoso
    Posted 2 years ago #

    1.6.13.8 is out, upgrade and it should fix the issue,

  8. weddingcentral
    Member
    Posted 2 years ago #

    I have the same issue, and it happened when I installed the new version - 1.6.13.8. I had to deactivate. Until it's fixed how can I revert to a previous version.

  9. Peter Baylies
    Member
    Posted 2 years ago #

    weddingcentral, you can get any previous version here; can you test and verify for me that 1.6.13.8 is what's causing your problem? Also which version of WordPress are you using, what theme and any other information you feel would be relevant about the problem and about your configuration.

  10. blazestudios23
    Member
    Posted 2 years ago #

    When I try to install I get this error:

    Plugin failed to reactivate due to a fatal error.

    Fatal error: Cannot redeclare class All_in_One_SEO_Pack in /var/www/vhosts/youcreatemoney.com/httpdocs/wp-content/plugins/all-in-one-seo-pack/aioseop.class.php on line 3

    I need to fix my menus, my live sites look terrible right now and that is going to hurt my business.

  11. blazestudios23
    Member
    Posted 2 years ago #

    I got it working on one site, but not the other yet. I am seeing if it may be some kind of persons issue and the funny thing is a 3rd site had not problem at all. It all just worked fine from the start.

  12. esmi
    Forum Moderator
    Posted 2 years ago #

  13. ireneu
    Member
    Posted 2 years ago #

    for me 1.6.13.8 fixes the issue

  14. blazestudios23
    Member
    Posted 2 years ago #

    I am still have the same error message on two sites, I tried changed permissions and that did not help, the 33-master-list didn't really help either.

    any ideas on how to fix the error message that shows up when you try to activate the plug-in?

    Fatal error: Cannot redeclare class All_in_One_SEO_Pack in /var/www/vhosts/youcreatemoney.com/httpdocs/wp-content/plugins/all-in-one-seo-pack/aioseop.class.php on line 3

  15. Peter Baylies
    Member
    Posted 2 years ago #

    It could be another plugin causing a conflict, try deactivating all your plugins and then activating just All In One SEO Pack and see if it works.

  16. blazestudios23
    Member
    Posted 2 years ago #

    It was a conflict between all in one SEO Pack and WordPress SEO by Yoast. Now it works fine.

  17. Sarah Anderson
    Member
    Posted 2 years ago #

    Also appears that some users using page menu editor plugin has had similar problems since 3.3 upgrade.

    That's incorrect. I fixed the Page Menu Editor plugin a month ago when 3.3 beta 2 highlighted the issue with my plugin.

  18. spinlessplates
    Member
    Posted 2 years ago #

    Thanks for the really quick update. Made a donation on your PayPal to say thank you.

  19. hurricane
    Member
    Posted 2 years ago #

    The update code was just copy & pasted from the original author's plugin.

    It's a shame that it's still without proper GPL attribution too, credit should be given where it's due.

  20. Brimfulof
    Member
    Posted 2 years ago #

    I'm still running WP 3.2.1 and it seems that the upgrade to AIOSEO 1.6.13.8 has broken the Menu Label functionality on my site. Is it possible that in fixing the issue for WP 3.3 it no longer works in earlier versions?
    I'm going to try rolling back to an earlier version of AIOSEO. I don't want to update to WP3.3 until most/all of the plugins are compatible.

  21. Sarah Anderson
    Member
    Posted 2 years ago #

    Is it possible that in fixing the issue for WP 3.3 it no longer works in earlier versions?

    My code certainly doesn't and the AIOSP code essentially duplicates that with the exception of post meta keys. There is version checks in place to ensure that the new change doesn't affect older sites as I released the update about a month ago or so.

    However, there have been a number of other updates to my plugin over the course of the year which have also been copied. Probably one of those, although I've not had any complaints off direct users, so maybe something's been altered to cause the issue.

  22. Michael Torbert
    WordPress Virtuoso
    Posted 2 years ago #

    hurricane,
    Attribution is given.

    Brimfulof,
    It should be working, but I'm looking into that now.

  23. Brimfulof
    Member
    Posted 2 years ago #

    Thanks for the quick response (and an excellent plugin). I've just reverted to Version 1.6.13.4 and Menu Labels are working again.
    I'm trying to figure out if it's a conflict with one of my other plugins or theme.
    Theme: Arclite
    Plugins: 30, but possible conflicts could be with WP Super Cache and Page Links Manager.
    Will report back if I get anywhere.

  24. Michael Torbert
    WordPress Virtuoso
    Posted 2 years ago #

    Brimfulof,

    Install http://wordpress.org/extend/plugins/wordpress-debug/ and send the debug information to
    aio [AT] semperfiwebdesign DOTCOM

    Also try clearing your cache.

  25. Michael Torbert
    WordPress Virtuoso
    Posted 2 years ago #

    Brimfulof,

    Can you email me directly with your WordPress login info? I'd like to take a look. I'm not able to recreate this issue on older versions of WordPress.

  26. hurricane
    Member
    Posted 2 years ago #

    @ Michael Torbert

    You may need to advise Automatic and the Free Software Foundation that you think a comment hidden within a PHP file supercedes the terms of the GPL licence and that you don't have to do more when using other people's work.

    I'd recommend reading the GPL which you're bound by as you've been in breach of it for 2 or 3 years.

  27. I'd be curious to see where in the GPL it mentions attribution outside of the source code is indeed required.

    There's no mention of it in v2
    http://www.gnu.org/licenses/old-licenses/gpl-2.0.html

    And it's optional in v3:
    http://www.gnu.org/licenses/gpl.html

    Here's a nice post:
    http://madebyraygun.com/blog/2011/attribution-and-the-gpl/

  28. Peter Baylies
    Member
    Posted 2 years ago #

    hurricane,

    Actually, requiring attribution is the reason why the original BSD license was incompatible with the GPL (v2) in the first place; that having been said, all the code is there, it's publicly available, and there's attribution provided on top of that. I'd argue that it's actually clearer to have a comment right there where the code is being used, as well.

  29. Ryan Duff
    Member
    Posted 2 years ago #

    I'm afraid I'm going to have to side with Andrea on this one. There is no attribution requirement for GPL software. As long as the licenses are compatible GPL2/GPL3/etc then you're literally free to copy and paste and do whatever you want without attribution.

    It is common courtesy to attribute someone else's code, a quick comment like the one that's included is more than enough to let others know where that code came from.

    Perhaps you should read the GPL... I think you're misunderstanding a few things.

  30. Sarah Anderson
    Member
    Posted 2 years ago #

    Seeing as the subject has been brought up, copied from the GPL linked to by Andrea_r, I believe hurricane is referring to

    You may copy and distribute verbatim copies of the Program's source code as you receive it, in any medium, provided that you conspicuously and appropriately publish on each copy an appropriate copyright notice and disclaimer of warranty;

    Conspiciously means noticeable. I don't think a comment hidden in the code is noticeable to about 95%+ of the users of the plugin? But that aside, there's no actual disclaimer of warranty in there either. I've always had one on my website's plugins section and more recently added it directly into the plugin, but as per WordPress's own plugin restrictions page, it comes under GPL v2 if there is no license present.

    You must cause the modified files to carry prominent notices stating that you changed the files and the date of any change.

    I don't believe that's there?

    I'm still running WP 3.2.1 and it seems that the upgrade to AIOSEO 1.6.13.8 has broken the Menu Label functionality on my site

    This is because a vital part of the code has been removed during the copy and as your theme uses span tags in the menu it's breaking it.

Topic Closed

This topic has been closed to new replies.

About this Topic