WordPress.org

1. RavanH
   Member
   Posted 1 year ago #

   Hi all,

   On http://wordpress.org/extend/plugins/wp-geo-mashup-map/ I've made a simple extension plugin for WP Geo available. It creates the possibility to show a Google Mashup map in any page or post content. Just put the shortcode [wp_geo_mashup] where you want it to appear.

   At this point it's just a very basic extension that adds a filter for the shortcode and uses one of the WP Geo internal functions to replace it with the mashup map. As I said: very basic. But in my opinion, a missing feature in WP Geo so I hope it may serve others too :)

   Rejoice the revival of and have fun with WP Geo!!

2. Ben Huson
   Member
   Posted 1 year ago #

   Will definitely try this out, thanks.

   I'm currently rewriting WP Geo to work with version 3 of the Google Maps API so at some point you may need to update your plugin. Subscribe to the WP Geo RSS Feed or follow @wpgeo on Twitter to keep up to speed with development and beta versions.

3. RavanH
   Member
   Posted 1 year ago #

   Hi Ben, great news! Your next version will certainly be something to look forward to :)

4. mamouneyya
   Member
   Posted 1 year ago #

   RavanH, I couldn't get your code working properly. Please take a look at this. I really appreciate any help.

5. Ben Huson
   Member
   Posted 1 year ago #

   Couldn't download from the link above.
   Is it uploaded correctly to the repository via SVN?

6. Ben Huson
   Member
   Posted 1 year ago #

   RavanH,

   I had to move the add_shortcode( 'wp_geo_mashup', 'shortcode_wpgeo_mashup' ); below the shortcode_wpgeo_mashup function in your plugin for it to work.

   - Ben

7. mamouneyya
   Member
   Posted 1 year ago #

   Ben, could you please help me with my issue?
   Thanks!

8. RavanH
   Member
   Posted 1 year ago #

   Hey Ben, lost track of this thread. My apologies for this late reply.

   If you still remember: Was it version 0.1 that did not work for you unless swapping the order? I have made the plugin going the official route via the init hook in version 0.2 so it should be alright there. If not, please let me know.

   Anyway, I have come across a bug that prevents get_wpgeo_map() from displaying functional javascript if a post title has a single quote (') mark in it.

   E.g. for a post with the title L'Abeille du Doux I get the error :
   

   Syntax error at line 10 while loading:
   pgeo_icon_small, 'L'Abeille du Doux', 'h
   --------------------^
   expected ')', got 'Abeille'

   I propose the part $post->post_title on line 218 in includes/templates.php should be something like js_escape($post->post_title) which I tested and works at least for single quotes. But there might be other escape routines more suitable here...

   Cheers :)

9. Ben Huson
   Member
   Posted 1 year ago #

   RavanH,

   You are right, that does need escaping.
   The js_escape() function was deprecated in WordPress 2.8 in favour of esc_js() so I've used that - I'm going to stop support versions of WordPress prior to 2.8 anyway.

   esc_js( $post->post_title )

   Will be added soon...

   - Ben

10. RavanH
    Member
    Posted 1 year ago #

    Excellent :)

11. Ben Huson
    Member
    Posted 1 year ago #

    Will be fixed in 3.2.1 (and 3.3.dev)

Topic Closed

This topic has been closed to new replies.