WordPress.org

Ready to get started?Download WordPress

Forums

Nginx
[resolved] Map validation (2 posts)

  1. Ed
    Member
    Posted 11 months ago #

    Hi Rahul,

    This isn't an error report, more of a validation idea for creating the Nginx map. We're using the WPMUDev domain mapping plugin, which has recently allowed multiple domains to be added to a blog. It appears that they've let through blank domains, so when Nginx Helper creates the map it just leaves the domain blank on the line but has the blogid at the end of it still. This causes Nginx to give:

    emerg] invalid number of the map parameters in /blog/location/wp-content/blogs.dir/1/nginx-helper/map.conf:8888

    Once I remove the failed domain and it's regenerated it's fine.

    I'm going to mention this to WPMUDev so they can fix it on their end, just thought you might like to know so you can build some validation into your plugin (if you haven't already).

    Apart from that, the plugin is working really well on a quite large Multi-site installation (9000+ blogs), so thanks again!

    Cheers,

    Ed

    http://wordpress.org/extend/plugins/nginx-helper/

  2. rahul286
    Member
    Plugin Author

    Posted 11 months ago #

    It appears that they've let through blank domains

    There is some mistake I guess. How can they allow blank domains? At the max only 1 blank domain will work as domain name has to be unique!

    EIther way, it looks like you have already debugged issue is details.

    If you can make a change, either in SQL query to fetch only non-blank domains or in PHP code which generats map - please feel free to send a pull request at https://github.com/rtCamp/nginx-helper

    We try to accept pull request within 24 hours. :-)

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.