WordPress.org

Ready to get started?Download WordPress

Forums

Subscribe2
[resolved] Just checking to be sure you know your widget breaks Jetpack Site Stats (30 posts)

  1. Eclectablog
    Member
    Posted 5 months ago #

    I want to be sure that you know that your widget breaks Jetpack Site Stats. I updated to WP 3.9 yesterday and now my Jetpack site stats have disappeared. No access to it in the dashboard, no indicator at the top of the blog page, and when I go to my bookmarked link I get the message "You do not have sufficient permissions to access this page." It's not even listed when I click the Jetpack tab. Also, the WP site stats page quit updating as soon as I upgraded.

    It turns out the issue is a conflict with the Subscribe2 widget. When I deactivate it, the Site Stats come back. People using Subscribe2 will have to wait until you resolve the problem in order to see site stats again or do without Subscribe2.

    https://wordpress.org/plugins/subscribe2/

  2. mattyrob
    Member
    Posted 5 months ago #

    @Eclectablog,

    I was aware of that from yesterday and checked in a fix earlier today:

    https://plugins.trac.wordpress.org/changeset/897276

    You might be able to use that above to fix this on your own site.

  3. Eclectablog
    Member
    Posted 5 months ago #

    @mattyrob, I appreciate that you have figured out a fix but I have no idea how to implement the things in that link. Could you possibly walk me through it?

  4. mattyrob
    Member
    Posted 5 months ago #

    @Eclectablog,

    Sure, actually it's pretty simple. First you need to know how to edit files running your blog, if you know about the plugin editor or FTP editing already skip forward a paragraph.

    The easiest way is to use the WordPress plugin editor but it may be disable. Try going to your Plugins menu and see if there is the word 'Edit' next to the Deactivate link. Click that and then find the classes/class-s2-core.php file in the right sidebar and click on that. If 'Edit' is not present then you'll need to FTP into your site, via cPanel is a good way, and then edit the file at wp-content/plugins/subscribe2/classes/class-s2-core.php.

    Once you've opened up the right file search for the following line:
    unset( $modules['stats'] );
    And replaced that with this:
    unset($modules['comments']);

    Save those changes, check you site is working and make sure you can now access the Stats section in Jetpack again.

  5. IPyandy
    Member
    Posted 4 months ago #

    this worked, thanks allot

  6. Eclectablog
    Member
    Posted 4 months ago #

    Thanks, mattyrob. This worked for me.

  7. dhochman
    Member
    Posted 4 months ago #

    That worked. Will you be releasing an updated plugin?

  8. mattyrob
    Member
    Posted 4 months ago #

    @dhochman,

    At some point yes, but it isn't going to be imminent. I'll see if any more bugs are identified and perhaps release around the same time as a point release of WordPress 3.9.

  9. pixelyzed
    Member
    Posted 4 months ago #

    Wow, a plugin disabling another plugin's functionality. That is seriously wrong IMO. I have a lot of clients who lost 2 days of stats because of that.

    If JetPack comments caused issues with your plugin (I don't use them so I wouldn't know), did you bring it up with them before disabling the functionality?

    Wow, the more I think about this, the worse idea it is. Leave other people's plugins alone, seriously. Or provide an option. Don't just do it without a clear warning (one line in an offsite log doesn't count...)

    Time to finish migrating sites to MailPoet...

  10. mattyrob
    Member
    Posted 4 months ago #

    @pixelyzed,

    You are welcome to your opinion but have a look in the Jetpack code for a list of all the plugins it currently conflicts with. Then consider how much of my time gets taken up by the fact that Jetpack comments completely and totally bypasses all comments code on hosted sites to use the form from WordPress.com (yes that says .com and it's right) instead of you site thus ignoring any and all code running on your sites that might add to or change your comment form.

    Good luck with MailPoet, just make sure to keep under 2,000 subscribers or you will start paying.

  11. pixelyzed
    Member
    Posted 4 months ago #

    @mattyrob

    I understand the reasoning behind what you did. I'm not saying there's an easy solution here and JetPack is indeed a beast. But you need to counterbalance this with the effect it may have on end users and the potential number of them affected. Your plugin has 1.2 million downloads, JetPack has nearly 10 million. The actual live installs ratio is probably even more heavily skewed in JetPack's favor. Before you disable functionality in a plugin with so many users I'd think a lot harder about it and other potential solutions.

    Today I was lucky that I found this thread quickly via Google and applied the fix I found here before I received more emails from irate clients. Lucky also that I can code and use InfiniteWP to send an updated zip to the sites I still have using Subscribe2. Your plugin is the last place I'd have looked for a problem with JetPack Stats so I could have lost a lot of time troubleshooting an issue actually unrelated to JetPack. I don't know what a less experienced WordPress dev will do in front of the same issue. You really need to consider this stuff too.

    My previous post probably came off harsher than it should have but I still think your "fix" is a terrible idea.

    As for MailPoet, I'm well aware of its subscriber limit. Free is not the main criteria I use to select a plugin or WordPress product in general. Quality is as I make a living building WordPress web sites and plugins that don't break my client sites will win over plugins that do every time, regardless if they're free or not. I manage dozens of WordPress installs for clients. I've come to value stability over other criteria long ago.

    With that said, don't get me wrong, I do think your plugin is a great plugin and I've used it on many sites for years. But moves like this can break my confidence in a dev quicker than anything. Kudos on reacting quickly over a holiday weekend though. That is much appreciated.

  12. mattyrob
    Member
    Posted 4 months ago #

    @pixelyzed,

    If I was earning a living from this code then I'd accept totally what you are saying but your concerns and assumptions only hold true if this this was a commercially viable and profitable venture. That, it is not.

    I'm on my own developing and supporting this plugin - mainly for my own use but shared so others can benefit. I don't have the luxury of MailPoets having 9 people working on developing and supporting their code or Jetpack with Automattic behind them.

    Jetpack has already caused me headaches because it breaks parts of my code. Subscribe2 can enable singing up to post notifications from the comment form, Jetpack Comments breaks that. Disabling the Comments section (disabling the Stats bit was a bug) in Jetpack is only done if the comments part of my code is enabled. If Jetpack Comments is enabled first then the appropriate part of my code is disabled.

    So, I have thought about it carefully and crafted the code as best I can to workaround Jetpack. But then I also did something stunningly stupid in deactivating the wrong module in Jetpack. In my defence I'll blame Jetpack for being overly complicated bloatware ;)

    [Edited for greater clarity]

  13. pixelyzed
    Member
    Posted 4 months ago #

    I hear you and my apologies for overreacting earlier. I do get that this is a free plugin (although I did run your paid HTML version on some sites :)

    The explanations in the third paragraph of your post are important. This is information I didn't have and would have mitigated my earlier reaction. Might be something you mention in the plugin FAQ as it's key information for people both using JetPack and your plugin. Going by both plugin's popularity, it might be quite a few people. Without the mistake disabling the wrong module, it wouldn't have affected me as I don't use JetPack comments but I'm sure many others do.

    Anyway, apologies again for overreacting. All is good now :)

  14. Odinkinder
    Member
    Posted 4 months ago #

    This change is not working for me. Still have a hole where my stats used to be.

  15. mattyrob
    Member
    Posted 4 months ago #

    @pixelyzed,

    No problem - I understand your reaction when your livelihood is at stake. What would be nice from my perspective is if website developers who use WordPress and Subscribe2 and other 'free' plugins to build sites for their clients built a donation for this 'free' software into their fee and passed this onto the plugin developer.

  16. mattyrob
    Member
    Posted 4 months ago #

    @Odinkinder,

    That's stange, it really should work. Try this instead then.In the classes/class-s2-core.php file fine this line:

    add_filter('jetpack_get_available_modules', array(&$this, 's2_hide_jetpack_comments'));

    And comment it out - change it to this:

    //add_filter('jetpack_get_available_modules', array(&$this, 's2_hide_jetpack_comments'));

  17. dixonge
    Member
    Posted 4 months ago #

    Natty rob...genius idea on donations!

  18. Odinkinder
    Member
    Posted 4 months ago #

    Got it back, thanks... :)

    I agree with Dix.... in fact, that's what I do when I set up a site, my clients pay out up front on what I call "core" plugins. I think the biggest drawback to the donation system is folks don't know what is appropriate for a donation, would a buck do? Five bucks?? Ten??? They don't want to insult the author by not donating enough, so they don't know what to do, then end up paying nothing. Perhaps a "suggested" donation??

  19. mattyrob
    Member
    Posted 4 months ago #

    @Odinkinder,

    I understand what you say about donations but it works the other way too, if I put a value on a 'suggested donation' it may well work to put people off if they don't think it's worth that suggested value.

    I really don't care what value people donate - I'm just as grateful for $1 as I would be for $50. I would expect that the donation is made in proportion to the benefits my plugin provides for each user.

    As said above Subscribe2 has been downloaded over 1 million times. I'd have been more than happy with 1cent for every download!

  20. Odinkinder
    Member
    Posted 4 months ago #

    And if they would have slipped you a buck, you would be a millionaire!
    (let's hope you are by now, or some day will be)

  21. mattyrob
    Member
    Posted 4 months ago #

    @Odinkinder,

    ROTFL!! A millionaire! I'm about a million miles away from being that. I'll keep dreaming that a dollar a download might happen one day. It's probably closer to 1cent per download but spread over 6 years.

  22. Brandon Kraft
    Happiness Engineer
    Posted 4 months ago #

    Howdy,

    Any timeline for releasing this fix to all, via a new version? There are still a fair number of folks reporting this to Jetpack support.

    Sadly, since Subscribe2 is deactivating the Stats module, mutual users impacted will permanently lose the stats information for the time using the current stable version, as Jetpack doesn't track stats at all when that module is not active.

    Cheers!

  23. mattyrob
    Member
    Posted 4 months ago #

    Hi Brandon,

    I would usually plan to release an update around the same time as WordPress 3.9.1 but since this appears to be affecting Jetpack support also I'll get it out in the next 24 hours.

  24. Brandon Kraft
    Happiness Engineer
    Posted 4 months ago #

    Much appreciated. I'll start telling folks to sit tight and an update is forthcoming.

    Thanks for your flexibility!

  25. mattyrob
    Member
    Posted 4 months ago #

    @Brandon,

    I've just pushed 9.4 as a rush job, that should fix this issue for you. Hope that helps.

  26. Odinkinder
    Member
    Posted 4 months ago #

    And if he gets it done, we should all slip him a buck.... :)

    I have been thinking about the whole "donation" thing..... ever been at an intersection, and there's a homeless standing there?? And what do you do? You give him a buck, maybe more. What has he done? Nothing, he was just standing there, in need of course, but he's just there. Don't get me wrong, charity is a good thing, it shows compassion for others, so it's all good. But, the bottom line is, he has contributed nothing...

    So now you got a guy coding an open source plugin, and maintaining it, for THOUSANDS of folks, and it's an essential for their sites..... I'd say he's contributed something, don't you think it might be worth the time to slip the author a buck or two??

    Just saying..... :)

    T.

  27. mattyrob
    Member
    Posted 4 months ago #

    @Odinkinder,

    I like your thinking ;)

    The more I think about open source 'free' software, the more convinced I am that as a model it will ultimately fail. I've seen a reasonable number of developers abandon their plugins - heck just look at the warning WordPress puts on plugins that haven't been updated for more than 2 years.

    Why does this happen? Well, as you say above we develops spend many hours looking after and developing our code for the benefit of our own sites and then we release that code so others can benefit too. We even support those plugins and help people out.

    All I ask for is a donation - as much or as little as you can spare is always received gratefully - it's not just the amour, it's the fact that you value the code enough to have made the effort to send me a little of your own cash.

    And then every now and then I get people who, simply because they chose to use my code, think I owe them something. That it's up to me to fix their site no matter how rude , aggressive and abusive they are.

    On many occasions I have been sorely tempted to abandon Subscribe2 and each time I reflect at these time I find it harder and harder to keep coming back - one day I will quit, but not just yet.

    I seriously hope I'm wrong about open source 'free' software and that it doesn't fail but only time will tell.

  28. Brandon Kraft
    Happiness Engineer
    Posted 4 months ago #

    As a quick plug, Subscribe2 has a donation link at http://wordpress.org/plugins/subscribe2/ that points to

    https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=2387904

    So yeah, if you haven't and you depend on Subscribe2, now is a great time :-).

    (Thanks again for the quick turnaround!)

  29. mattyrob
    Member
    Posted 4 months ago #

    @Brandon,

    Thank you for the plug and also your donation. My apologies for causing you support headaches in trying to reduce mine!

  30. Odinkinder
    Member
    Posted 4 months ago #

    Hey Matty,

    Open source is a good thing, since you can involve other creative minds besides your own, development can move so much quicker.

    That said, "getting paid," is the Achilles of open source, and if something is not done we will lose our best and brightest authors because it's just not financially prudent.

    I have a similar problem over at my on line motorcycle magazine, The Biker's Garage. I put a considerable effort into my magazine, but, it has yet to earn any real money. I can spend days generating original content, making photographs, researching, writing. It's actually quite a time drain. It's been doing well in other ways, I'm seeing six to seven thousand visitors a month, so the content is useful, and popular. The downside is money, I have Google ads in the side bars, and I just picked up Amazon, fingers crossed I get some sales there.

    I think the issue is that my readers don't know how I make money, they don't know to "click out" on a Google ad leaving my site, and they don't understand I can make money from the stuff they buy on Amazon. Perhaps they just see the ads and think I'm being paid for them like in a print magazine.

    I'm at a point where I'll have to decide if I will continue or not. Nobody will feed me for free, so I have to make a choice where to spend my effort, my web development and SEO work, or the magazine. I'm considering actually writing an article, "Support The Biker's Garage," and lay it all out in regards to the money, that way people can understand and choose the "correct" action to take.

    They always say "You get what you ask for." So I'm going to ask, I suggest you might want to do the same. Personally, I think a suggested donation of 1.00 USD is not too much to ask.

    T.

Reply

You must log in to post.

About this Plugin

About this Topic