Just to let you know, There's still a few issues with paths.
- NEVER hard code
wp-contentin the plugin, that's just asking for trouble for those of us who use custom WP_CONTENT_DIR's.. probably best to use dirname(__FILE__) instead maybe?
- The Include path is still set incorrectly in
class-wp-filesystem-ssh2.phpalthough it's set right in
sftp.phpso it's not really a problem
- You seem to be attempting to force ssl usage through the filesystem_method filter via
phpseclib_filesystem_method(), however this doesn't actually work, as it's hooked via
add_filter()- I'd suggest removing that action/function myself, and let the radio selections take over
- When running with WP_DEBUG mode, phpseclib throws a PHP notice for an undefined constant on every file operation:
Notice: Use of undefined constant NET_SFTP_APPEND - assumed 'NET_SFTP_APPEND' in ssh-sftp-updater-support/phpseclib/Net/SFTP.php on line 1282
- I notice in the chmod() method, you're not setting it if it's called with a false mode, Are you aware of why it's being called with a false mode? Core sets it for every request due to the number of server configurations where not setting it was causing security implications, For SSH, it's probably fine not to set it for every request, but it seems strange that it should ever get called with a false mode.
I think that's everything.. I've been meaning to ask the above questions as I've been testing it out, Just haven't gotten around to it until now!
If you've got any questions on any of the upgrade stuff, give me a yell? wordpress at dd32.id.au