index.php in wp-content proper?

  • Pioneer Web Design

    (@swansonphotos)


    10 years, 11 months ago

    I am using WinMerge to compare files on a site. I have just downloaded WP3.5.1 – the site was updated to 3.5.1 within a day or so of it’s release using the built-in core update feature on live site.

    Note: I see forum posts on this, including: yup, there was a diff between the files available for download and the svn repository (used to do the site updates) – yet, I cannot see anyone from WP – mods etc. clearly noting which is the correct version!

    Issue:

    The file on the server has this:

    <?php
// Silence is golden.

    The file just downloaded has this:

    <?php
// Silence is golden.
?>

    The Diff being the third line.

    Which should it be (for the current version 3.5.1 of WP)?

Viewing 5 replies - 1 through 5 (of 5 total)
  • Krishna

    (@1nexus)

    10 years, 11 months ago

    The first one is left unclosed, probably, purposefully. As per notes I found on this in php sites, the closing ?> is not required. There are forum posts on this issue too, though I do not remember which, but can be located.

    So, it is incorrect to say that no one noticed it or mentioned about it in forums.

    Krishna

    (@1nexus)

    10 years, 11 months ago

    Review:
    http://php.net/manual/en/language.basic-syntax.instruction-separation.php

    Thread Starter Pioneer Web Design

    (@swansonphotos)

    10 years, 11 months ago

    @krishna,

    Sure, like I said, I saw it discussed in the forums, just did not find a direct answer as to which to use from WP (or why – from WP folks).

    I guess my point is that such a simple file should just match at download/repository…why leave folks wondering?

    Krishna

    (@1nexus)

    10 years, 11 months ago

    I cannot see anyone from WP – mods etc. clearly noting which is the correct version!

    The question comes up only when someone asks or someone says which is correct or which is NOT correct. I saw a pointed question on this from you and I replied.

    The question has its relevancy only if you can say for certain any one of the versions is incorrect. Can you say if any of the two is incorrect? If no, what is the problem?

    Personally, I would say both are correct and you can use whichever version you like, provided it is the latest version.

    Thread Starter Pioneer Web Design

    (@swansonphotos)

    10 years, 11 months ago

    @krishna,

    I get that (now)…again, my point is that I was doing a file compare and they were different…so I had to do the research <===that is what should not have to be done. Period!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘index.php in wp-content proper?’ is closed to new replies.