WordPress.org

Ready to get started?Download WordPress

Forums

Clean Yeti Basic
[resolved] Improve internationalization of comment form (2 posts)

  1. Daedalon
    Member
    Posted 6 months ago #

    1. Library/extensions/comment-extensions.php contains neat options to override certain strings with own translations. There are a few strings missing this on lines 238-244. They're all ran through sprintf, but that shouldn't hinder translation at all.

    The string to be ran through sprintf should be obtained in the same way as the other strings. For example it should be possible to override Logged in as %s with for example Kirjauduttu sisään käyttäjänä %s for Finnish.

    Using a translation file is still a nightmare for many use cases as it gets automatically overwritten or deleted on plugin updates. WordPress core team is working on an update to allow better translation file management. In the meanwhile we would be best served with the override functions.

    2. If you'll switch the translated string Log out? to be Log out and then append the question mark, you can make use of WordPress core translation and be immediately translated to dozens of languages. I would also vouch for putting brackets around the text instead of a question mark after, so that we'd have it the same way as on here on WordPress.org: Logged in as Username (Log out). And when the brackets are inside the same span class="logout", the siteadmin can now theme this with CSS.

  2. Richard LaFranchi
    Member
    Theme Author

    Posted 6 months ago #

    I've updated number 2 as recommended and will upload the changes along with the others.

    As for number 1. I've built the theme off of Thematic and I believe this may be a question for the guys from Thematic. I had a dilemma as to whether or not to include the translation files as provided by Thematic. I've been doing some work for a bilingual site that uses the WPML plugin, which I've found to be very useful. You can use the plugin to scan themes and plugins for strings and translate accordingly or choose to use the theme's POT files. I just looked and Thematic hasn't been updated in 10 months, so it's possible that it's been scrapped.

    I believe you could override in a similar manner to how you overwrote the nav menu args.

    function my_args($args) {
    $args['logged_in_as'] = '<p>Some new input field here</p>';
    return $args;
    }
    add_filter('cleanyetibasic_comment_form_args','my_args');

Reply

You must log in to post.

About this Theme

About this Topic

Tags

No tags yet.