HTTPS issue

  • Andrew

    (@anpal79)


    10 years, 12 months ago

    Helo, great plugin, thanks!

    However mentioned a mistake.
    You should use

    $protocol = is_ssl() ? 'https' : 'http';
$url = $protocol."://www.some.url/some.resource";
echo $url;

    instead of

    $url = "http://www.some.url/some.resource";
echo $url;

    everywhere you insert some resources into a page.

    Without this corrections site appears as not fully secured even with valid ssl sertificate (cause some page’s referenced resources are not encrypted)

    Regards,
    Andrew

    http://wordpress.org/extend/plugins/theme-my-login/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Jeff Farthing

    (@jfarthing84)

    10 years, 12 months ago

    What are we talking about here? The stylesheet?

    Thread Starter Andrew

    (@anpal79)

    10 years, 12 months ago

    I’ve patched theme-my-login/modules/recaptcha/recaptcha.php to fix it.
    Maybe there something else in code..

    Changes needed in
    const RECAPTCHA_API_URI
    and
    function wp_enqueue_scripts

    I’ve substituted them with

    public static function RECAPTCHA_API_URI(){
	    $protocol = is_ssl() ? 'https' : 'http';
	    return $protocol.'://www.google.com/recaptcha/api';
	}

    and

    function wp_enqueue_scripts() {
		$protocol = is_ssl() ? 'https' : 'http';
		wp_enqueue_script( 'recaptcha', $protocol.'://www.google.com/recaptcha/api/js/recaptcha_ajax.js' );

    respectively.

    There are also some href-s in /includes/class-theme-my-login-ms-signup.php

    Regards,
    Andrew

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘HTTPS issue’ is closed to new replies.