WordPress.org

Ready to get started?Download WordPress

Forums

HTML Enclosing the_title() Not Writing (12 posts)

  1. maryjanesfarm
    Member
    Posted 1 year ago #

    In a page, using a theme derived from TwentyTen and using onecolumn-page.php, the section that calls the_title() is not writing out the <h1> or <h2> tags that surround it.

    I've apparently only customized the page by adding a check for whether the_title() even has content. That check is not returning false, because I get the title written out to the page - it's just not enclosed in the heading tags as it should be.

    I tried inserting the heading tags as $before and $after within the_title(), but then saw that the function applies strip_tags() to its output.

    I can't for the life of me figure out why the heading tags are not being written to the page:

    <?php if ( the_title() != "" ): ?>
    	<?php if ( is_front_page() ) { ?>
    		<h2 class="entry-title"><?php the_title(); ?></h2>
    	<?php } else { ?>
    		<h1 class="entry-title"><?php the_title(); ?></h1>
    	<?php } ?>
    <?php endif; ?>
  2. esmi
    Forum Moderator
    Posted 1 year ago #

    What happens when you use the original Twenty Ten theme?

  3. maryjanesfarm
    Member
    Posted 1 year ago #

    Why, it just displays it right as rain, of course.

    So ... that's interesting. Why would adding one enclosing if statement change a durn thing? Guess I'll try getting rid of the added if statement in my customized theme to see if that makes a difference...

    (Good call, esmi.)

  4. esmi
    Forum Moderator
    Posted 1 year ago #

    Where are you actually trying to use that code snippet? Within the loop of the custom page template?

  5. maryjanesfarm
    Member
    Posted 1 year ago #

    When I remove my added if statement, the <h1> gets inserted around the title again.

    The code I provided above is in the exact same place as it is in TwentyTen, on loop-page.php. So, loop-page.php gets called by onecolumn-page.php.

    And, yes, the snippet as well as the current code gets called within the loop. Here's the complete structure from loop-page.php, with my customization now removed:

    <?php if ( have_posts() ) while ( have_posts() ) : the_post(); ?>
    
    	<div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    		<?php if ( is_front_page() ) { ?>
    			<h2 class="entry-title"><?php the_title(); ?></h2>
    		<?php } else { ?>
    			<h1 class="entry-title"><?php the_title(); ?></h1>
    		<?php } ?>
    
    		<div class="entry-content">
    			<?php the_content(); ?>
    			<?php wp_link_pages( array( 'before' => '<div class="page-link">' . __( 'Pages:', 'twentyten' ), 'after' => '</div>' ) ); ?>
    			<?php edit_post_link( __( 'Edit', 'twentyten' ), '<span class="edit-link">', '</span>' ); ?>
    		</div><!-- .entry-content -->
    	</div><!-- #post-## -->
    
    	<?php /* comments_template( '', true ); */ ?>
    
    <?php endwhile; // end of the loop. ?>
  6. esmi
    Forum Moderator
    Posted 1 year ago #

    So what you're trying to do is stop the heading tags being generated when there isn't a Page or Post title, yes? How would you square that against the fact that the Page or Post may contain sub-headings as part the_content() and that, by removing the heading tags, you've disrupted the (hopefully) logical heading tag order?

    What about auto-generating a title if there isn't one instead? Just add this function to the child's functions.php file:

    function my_autogenerate_title( $title ) {
    	if ( !$title ) $title = __('No Title', 'twentyten');
    	return $title;
    }
    add_filter( 'the_title', 'my_autogenerate_title' );
  7. maryjanesfarm
    Member
    Posted 1 year ago #

    Correct. I wanted no heading tags if there was no page title.

    If I follow what you're saying, the site I'm managing is not well enough structured to worry about maintaining heading structure. (By "logical heading tag order", you mean that the topmost tag is an h1, the next an h2, and so on to h4s, h5s, etc, correct?)

    For the pages (and this only applies to pages, not posts), if I leave the title out, I don't want it to have a title. (Posts, conversely, are required to have a title.) Pages are not automatically presented anywhere within a site menu structure; I have to link to them specifically. In this instance, the link is in the footer, because I'm using a page to create the Privacy Policy. Also, in this instance, I did want the page's title of "Privacy Policy" displaying; whereas I did not want titles displayed on "static" informational-type pages I had previously created.

    Thus, I also wouldn't want to auto-generate a title if one is missing.

  8. esmi
    Forum Moderator
    Posted 1 year ago #

    Try:

    <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    		<?php if (!get_the_title() ) :
    		if ( is_front_page() ) { ?>
    			<h2 class="entry-title"><?php the_title(); ?></h2>
    		<?php } else { ?>
    			<h1 class="entry-title"><?php the_title(); ?></h1>
    		<?php }
    		endif;?>
  9. maryjanesfarm
    Member
    Posted 1 year ago #

    Whee! What the heck!? That makes even less sense.

    Oh, wait! I need the inverse - if ( get_the_title() ) ... [removed the NOT operator].

    Without the NOT operator, yes, that works - no heading tags when the title is empty; heading tags written out along with the title when it has content.

    I don't know what the effective difference is between what you did and what I did, except that yours works.
    Well, if you've got an explanation, great; either way, thank you for looking that over. :)

  10. esmi
    Forum Moderator
    Posted 1 year ago #

    I need the inverse - if ( get_the_title() )

    Sorry! My bad! Glad to hear that you got it working anyway. :-)

  11. alchymyth
    Forum Moderator
    Posted 1 year ago #

    I don't know what the effective difference is between what you did and what I did

    <?php if ( the_title() != "" ): ?>

    vs

    <?php if (!get_the_title() ) :

    the function the_title() prints or echoes the title which makes it non-available for any conditional check;

    while get_the_title() returns the title which then is available for the contitional check.

    http://codex.wordpress.org/Function_Reference/the_title
    http://codex.wordpress.org/Template_Tags/get_the_title

  12. maryjanesfarm
    Member
    Posted 1 year ago #

    Oh! sheesh. I even know that, duh, but it wasn't occurring to me what's happening with a function that's echoing (by default). And that's probably where the untagged printout on the page was coming from, which once printed left the conditional check unverified (as you're pointing out) so that it wouldn't echo the entire tag and title set.

    So many little things I have to keep straight in programming still. Thank you.

Topic Closed

This topic has been closed to new replies.

About this Topic