WordPress.org

Ready to get started?Download WordPress

Forums

Google Maps Ready!
[resolved] Generates non-valid HTML, suggested fix (3 posts)

  1. LiamLaverty
    Member
    Posted 3 months ago #

    Hey,

    The plugin is great, but generates non-standard html. I made a suggestion for a quick fix on Github, which redirected me here. You can see the suggestion here:

    https://github.com/liamlaverty/google-maps-ready/compare/patch-1

    The issue is that there's a <style> tag where there shouldn't be one. All I did was add it to the wp_head hook.

    https://wordpress.org/plugins/google-maps-ready/

  2. Ready! Developer
    Member
    Posted 2 months ago #

    Hello.
    Thank you for support, this is great.
    But did you tried this solution? I understand what you mean - put all <style> tag inside <header> using wp_head hook. I can but to such callback all variables (like $mapWidth, $height, etc.), but shortcode can be in any place of content, most likely it will be in post or page content, and wp_head event will be already triggered at moment when we start draw map, so it will not output styles on user page. Maybe I didn't understand fully your idea, if so - can you please explain it more?

    Regards,
    Alexey.

  3. Google Maps plugin
    Member
    Plugin Author

    Posted 1 month ago #

    Hello.
    Unfortunatelly, we didn't found out solution to generate data into <head> when shortcode is called after <head> was generated. I think in current wordpress shortcodes functionality this is impossible.

    Regards,
    Alexey.

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.