WordPress.org

Ready to get started?Download WordPress

Forums

Fixes for the invalid XHTML with the Elegant Twitter Widget (1 post)

  1. Justin Tadlock
    Member
    Posted 5 years ago #

    I wasn't sure where to leave this for the plugin author. I hope this finds him. The plugin is stated as having valid XHTML, but this is not always the case. Maybe it'll help with the next version of the plugin.

    The plugin makes the assumption that all widget areas have markup such as this, which is not an assumption we can make:

    <ul>
    	<li></li>
    	<li></li>
    </ul>

    Lines 24 - 26 of elegant-twitter-widget.php:

    <li id="twitter-sidebar" class="widget widget_twitter">
    
    	<h3 class="widgettitle">twitter</h3>
    
    	<ul id="twitter-list">

    Are marked up incorrectly. They should look like this:

    <?php
    	echo $before_widget;
    	echo $before_title . 'Twitter' . $after_title;
    ?>
    	<ul id="twitter-list">

    Line 51:

    </li>

    Should be:

    <?php echo $after_widget; ?>

    I would also argue that it'd be beneficial to allow users to input their own custom widget title.

    http://wordpress.org/extend/plugins/elegant-twitter-widget/

Topic Closed

This topic has been closed to new replies.

About this Topic

  • RSS feed for this topic
  • Started 5 years ago by Justin Tadlock
  • This topic is not a support question
  • WordPress version: 2.8