WordPress.org

Ready to get started?Download WordPress

Forums

Enhanced Media Library
[resolved] filter in media not working properly (22 posts)

  1. e-crespo
    Member
    Posted 9 months ago #

    Hello,

    Wonderful plug-in!
    But filtering by media-category in media library does not work properly. It only shows one file or nothing and I have checked database and term relationships are ok, etc.

    Any hint, is this normal or an identified bug?

    Thanks in advance

    http://wordpress.org/plugins/enhanced-media-library/

  2. webbistro
    Member
    Plugin Author

    Posted 9 months ago #

    Hello,

    Thank you for letting me know about the issue. I tested it and figured out that non-media (post) taxonomies' sorting is not working properly in Media Library. I think, you might have a problem because of this. Please upgrade the plugin and let me know if the issue is gone.

    Nadia

  3. e-crespo
    Member
    Posted 9 months ago #

    Hi again,

    I have just upgraded to 1.0.3 and filter is still not working properly. I am yet only testing with media-taxonomies (default media-categories) so I do not think it has something to do with that.

    However filters when attaching/adding media in a post or page work perfectly well. It is only happening in Media Library and it's quite strange because it shows 1 or 2 or 3 media files associated with an specific media-category but not all. It is quite confusing...

    Thanks in advance with any help

  4. webbistro
    Member
    Plugin Author

    Posted 9 months ago #

    Hello,

    Then, please, try deactivate all other plugins and check again. If you find a plugin that causes the conflict please let me know its name. Also you can try to change theme to any of WP default to check if the issue still be actual. It looks like something else affects WP query for media library page.

    Nadia

  5. webbistro
    Member
    Plugin Author

    Posted 9 months ago #

    Hello,

    Any information? Is the issue still actual for you?

    Nadia

  6. e-crespo
    Member
    Posted 9 months ago #

    Ok, I will try to figure out what is conflicting with that page view specifically.

    I expect to give you feedback in a couple of day...

    Enrique

  7. webbistro
    Member
    Plugin Author

    Posted 9 months ago #

    Thank you Enrique. I am really willing to help you with it, it's also a potential bug I could be unaware of, but I have to get some information about your conditions.

  8. martylouis
    Member
    Posted 9 months ago #

    I've had a similar issue with filtering. On WP v3.7.1, and I've turned off all plugins.

    I've noticed an issue with the url. It looks like s& is appended to /upload.php? that is preventing a successful filter.

    Click Filter once (fail):
    wp-admin/upload.php?s&action=-1&m=0&media_category=11&paged=1&action2=-1&affected&_ajax_nonce=fe0127a0dd&ps

    Clicking filter a second time (success):
    wp-admin/upload.php?action=-1&m=0&media_category=11&paged=1&action2=-1&affected&_ajax_nonce=fe0127a0dd&ps

    This fail/success occurs with each subsequent "Filter" click.

    Hope this helps.

  9. webbistro
    Member
    Plugin Author

    Posted 9 months ago #

    Hello Marty,

    Thank you for the information! So far I can't get it. I just tested wp 3.7.1 again, and filter worked as expected with or without s& no matter how many times I pushed Filter button.

    Are you still experiencing same issue with EML 1.0.3? Can you please describe your usual sequence of actions? What were you doing just before starting filtering your files?

    Thank you.

    Nadia

  10. craig100
    Member
    Posted 8 months ago #

    Hi,

    Just installed this in a 3.8 site and get the same problem as others. The Filtering at the top of the Media page doesn't work. It only shows 1 item when there are many others. However, if you go to the Categories page and click on the number of images against each category then you see a correctly filtered list.

    I've removed this plugin now as it will only confuse people if it doesn't work. But hope this helps you fix it.

    Cheers,

    Craig

  11. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Hello all,

    Unfortunately I wasn't able to reproduce the issue for WP 3.7, nor for WP 3.8. Nevertheless, I have re-coded the queries for Media Library filters, hope this will solve the problem.

    Please let me know if the issue is gone in EML 1.0.4. Thanks in advance!

    To Craig: I don't think the plugin "doesn't work". According to your and others description, the taxonomy filter in Media Library doesn't work properly for some users for unknown (so far) reason. It is not the only one, nor the main plugin's feature. In addition you can turn this feature off.

    Nadia

  12. beckend
    Member
    Posted 8 months ago #

    1.0.4 on wordpress 3.8.

    Still the "s&" kills the filtering, pressing filter button a second time fixes it, why don't you just remove "s&" from the code?

  13. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Because, it's standard WP request. EML doesn't form it. Empty search string could break the query in NO way. Very strange issue...

    Could you please give me an access to your website or assist a bit in testing queries for it? If so, please email me to wordpressuxsolutions [at] gmail [dot] com
    I will be really grateful.

    Nadia

  14. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Also, could you please check your date filter (default filter before Media Category). It works in the same way as EML custom filters. Do you have similar problem with sorting by date? Thank you!

  15. beckend
    Member
    Posted 8 months ago #

    Date filtering acts same, broken first try, ok second.
    Where should I send you the login info?

  16. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Here please - wordpressuxsolutions [at] gmail [dot] com

    Thank you!

  17. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Thanks again!

    In your case, the problem is in your theme - Roots.

    roots-master/lib/cleanup.php

    line 244

    function roots_request_filter($query_vars) {
      if (isset($_GET['s']) && empty($_GET['s'])) {
        $query_vars['s'] = ' ';
      }
    
      return $query_vars;
    }
    add_filter('request', 'roots_request_filter');

    This filter breaks the query for Media Library with or without active EML. You can easily check it yourself by commenting this line:

    //add_filter('request', 'roots_request_filter');

    or changing Roots theme.

    Please, contact theme author to fix it.

    Nadia

  18. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Everyone, please if you have this issue:

    1. Check if the date filter is working correctly, it is WP filter by default, if it's not working properly, the problem is not EML, which uses the same native WP mechanism, but one of the plugins or themes.
    2. Deactivate other plugins and change your current theme to one of WP "native" themes and check if it still be not working. In this way you can help me to find a plugin or theme that causes this issue.

    If date filter is working correctly for you, and other plugins and themes do not affect the issue, then please let me know.

    Thanks in advance!

    Nadia

  19. manifestcreative
    Member
    Posted 8 months ago #

    Hi Webbistro,

    Awesome plugin! Overall it works and functions great, however I'm having a very similar problem as earlier posters.

    With all plugins disabled, except EML, I'm able to filter by the core date menu, but not by either of the 2 taxonomies I've assigned to EML. Filtering within the media editor modal (when editing a post) seems to work correctly, just not on the media library page.

    Let me know if you need any additional info and I'll happily help you track this bug down.

    Thanks!

  20. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Hello All,

    Since no one denoted any problem during last week I am marking this issue as resolved, but feel free to let me know should you have similar issue in future.

    Nadia

  21. webbistro
    Member
    Plugin Author

    Posted 8 months ago #

    Hello @manifestcreative,

    it seems we were typing our responses simultaneously :)

    Please, check also your theme (change it to any default WP one). If the problem still persists please send me access to your project.

    wordpressuxsolutions [at] gmail [dot] com

    I won't break your website in any way, no worries.

    Thanks!

    Nadia

  22. manifestcreative
    Member
    Posted 8 months ago #

    Hi @webbistro,

    Thanks for your speedy response. I'll send you login credentials for the site, but it's a bit difficult for me to test on a default theme as the media taxonomies themselves are heavily dependent on the custom theme.

    I think you'll see what I mean once you log-in.

    I'm also noticing that when I click on one of my taxonomy management pages, then click the linked number of media files that are assigned to a term, it still doesn't filter properly. Because this is a core feature I'm leaning towards it being something in my theme or the EML plugin.

    It's got me stumped tho!

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.