WordPress.org

Ready to get started?Download WordPress

Forums

WP-Filebase Download Manager
[resolved] filebase 0.2.9.35 problem (14 posts)

  1. Adrian
    Member
    Posted 1 year ago #

    filebase 0.2.9.35 messed up the formatting of all pages with wp-filebase shortcodes.

    Maybe 0.2.9.35 introduced a conflict with another plugin, but I wasn't able to confirm that or figure out which plugin might have been conflicting.

    I downgraded to filebase 0.2.9.34 and it's working fine again.

    http://wordpress.org/extend/plugins/wp-filebase/

  2. tray
    Member
    Posted 1 year ago #

    interesting. i'm having the same issue. took the same steps and that worked as well.

    i also noticed (when i was being all stubborn and trying to troubleshoot it a bit so i didn't have to downgrade) that the page choked on the first file attachment in my default format... but not when using the simple format of a link.

    also i noticed this new error across the top of the main WP-Filebase admin screen:
    "File Browser post or page not set! Some features like search will not work. Click here to set the File Browser Post ID."

    and the "Post ID of the file browser" setting wouldn't allow me to leave the space blank (it would auto populate with a 0 after save), and then gave me an error message:
    "Warning: The Filebrowser page has at least one subpage Contact us. This will cause unexpected behavior, since all requests to the subpages are redirected to the File Browser Page. Please choose a Page that does not have any subpages for File Browser."

    so.. not sure if that was causing this error or not... or is related at all.

  3. Fabian
    Member
    Plugin Author

    Posted 1 year ago #

    tray, you can ignore that new error message, it should only show up if you have actually set the Post ID to something different than 0. Will fix this with the next update.

    About the formatting issue:
    Can you provide a URL of the page?
    What templates are affected?

  4. tray
    Member
    Posted 1 year ago #

    since the site is live, i just rolled back to the previous version to fix the formatting. but the even more strange thing about the error was that when i viewed the source code for the page, the error was not found and all the code was in tact, all the way to the bottom.

    not sure if that helps at all. if you'd like, i can set up a dev site and try to replicate the error.

    one other note is that this is on a WordPress multisite setup. not sure if that makes any difference.

  5. Adrian
    Member
    Posted 1 year ago #

    My site which had this problem is also a live site.
    I backed down to 0.2.9.34 so I can't give you a URL which demonstrates the problem.
    However mine is not a multisite setup.
    I think there must have been some php problem which prevented the complete page being generated because the widgets which normally appear in the right navbar didn't show.
    Previous errors like this have been caused by a variable naming conflict.

  6. Fabian
    Member
    Plugin Author

    Posted 1 year ago #

    Its most likely a syntax error in your file template. Please post the code here.

    Before 0.2.9.35, html comments in templates were removed. This has changed since it also strips embedded JavaScript code.

    Now with a syntax error in a template, it can happen that there's a HTML comment begin (<!--) but missing end (-->)

  7. tray
    Member
    Posted 1 year ago #

    alright. i re-updated my plugin, now that it's the middle of the night. the template that seems to be "choking" is the "default" template. (code pasted below) i didn't change this template at all, so it should still all be the same as what came with the plugin originally.

    <div class="wpfilebase-attachment">
     <div class="wpfilebase-fileicon"><a href="%file_url%" title="Download %file_display_name%"><img align="middle" src="%file_icon_url%" alt="%file_display_name%" /></a></div>
     <div class="wpfilebase-rightcol">
      <div class="wpfilebase-filetitle">
       <a href="%file_url%" title="Download %file_display_name%">%file_display_name%</a><br />
       %file_name%<br />
       <!-- IF %file_version% -->%'Version:'% %file_version%<br /><!-- ENDIF -->
       <!-- IF %file_post_id% AND %post_id% != %file_post_id% --><a href="%file_post_url%" class="wpfilebase-postlink">%'View post'%</a><!-- ENDIF -->
      </div>
      <div class="wpfilebase-filedetails" id="wpfilebase-filedetails%uid%" style="display: none;">
      <p>%file_description%</p>
      <table border="0">
       <!-- IF %file_languages% --><tr><td><strong>%'Languages'%:</strong></td><td>%file_languages%</td></tr><!-- ENDIF -->
       <!-- IF %file_author% --><tr><td><strong>%'Author'%:</strong></td><td>%file_author%</td></tr><!-- ENDIF -->
       <!-- IF %file_platforms% --><tr><td><strong>%'Platforms'%:</strong></td><td>%file_platforms%</td></tr><!-- ENDIF -->
       <!-- IF %file_requirements% --><tr><td><strong>%'Requirements'%:</strong></td><td>%file_requirements%</td></tr><!-- ENDIF -->
       <!-- IF %file_category% --><tr><td><strong>%'Category:'%</strong></td><td>%file_category%</td></tr><!-- ENDIF -->
       <!-- IF %file_license% --><tr><td><strong>%'License'%:</strong></td><td>%file_license%</td></tr><!-- ENDIF -->
       <tr><td><strong>%'Date'%:</strong></td><td>%file_date%</td></tr>
       <!-- <tr><td><strong>%'MD5 Hash'%:</strong></td><td><small>%file_hash%</small></td></tr> -->
      </table>
      </div>
     </div>
     <div class="wpfilebase-fileinfo">
      %file_size%<br />
      %file_hits% %'Downloads'%<br />
      <a href="#" onclick="return wpfilebase_filedetails(%uid%);">%'Details'%...</a>
     </div>
     <div style="clear: both;"></div>
    </div>
  8. tray
    Member
    Posted 1 year ago #

    ok. nevermind. it seems like the problem resolved itself for me after downgrading, and re-upgrading again... strange.

  9. Adrian
    Member
    Posted 1 year ago #

    I reinstalled 2.9.35
    the problem of messed up formatting is still present
    I looked in the generated HTML and found an unclosed comment like you suggested:
    <!--

    There are quite a few occurrences of
    in the generated HTML on my WordPress site so I have to check where they are coming from.

  10. Adrian
    Member
    Posted 1 year ago #

    The comment should have been shown as
    <!--<br />

  11. Adrian
    Member
    Posted 1 year ago #

    This unclosed comment looks as though it's in a section of code generated by WP-Filebase 2.9.35
    Here is a longer extract

    <td><strong>Date:</strong></td>
    <td>1 February, 2013</td>
    </tr>
    <p>   <!--<br />
    <tr>
    <td><strong>MD5 Hash:</strong></td>
    <td><small>ecf5faa0746cb6c09807b8dbb7c1b5a0</small></td>
    </tr>
    <p> –><br />
      </table>
    </p></div>
    </p></div>
    <div class="wpfilebase-fileinfo">
      1.3 MiB<br />
      154 Downloads<br />
      <a href="#" onclick="return wpfilebase_filedetails(1);">Details…</a>
     </div>

    I'm going to revert to 2.9.34 again

  12. Fabian
    Member
    Plugin Author

    Posted 1 year ago #

    adriandw, please post your template code here.

  13. Adrian
    Member
    Posted 1 year ago #

    I can post the template code if you like but I'm just using the default Filebase template.

  14. Adrian
    Member
    Posted 1 year ago #

    I have upgraded from 2.9.34 to 2.9.36 and the problem has gone away.
    Thank you.

    Adrian

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.