Feedback – tags/categories

Actually, maybe I can help with a minor thing. Using this shortcode:
[testimonialswidget_list limit=1 random=true paging=false] outputs incorrectly nested HTML – there’s an opening <p> before the quote span without a closing tag.

In testimonials-widget.php, line 861, if you move the ‘force_balance_tags’ outside of that if() structure, the tags balance even if you haven’t set a charlimit.

~~~~~
Also, if you apply the ‘open-quote’ and ‘close-quote’ classes to their respective parent <p> tags, it’d be much easier to style up. As the <p> tags are block elements, they span the full width of the blockquote, so we generally need to style these p tags by floating them or positioning them absolutely. As it stands it’s hard to target them as they don’t have a class, whereas if you moved the class from the <span> to the <p>, you could target the <p>, but you could still target the span as a descendent i.e. blockquote p.open-quote span {whatever}

Hope that makes sense?

Thanks

Hi Michael,thanks for the reply.

Custom Taxonomies – just to clarify, I wasn’t referring to any custom post types I’d set up, I just mean that using the in-built taxonomies for your testimonials post type could cause issues where the in-built taxonomies are used elsewhere. If we’re on the same wave-length here, great!

Open/Close Quote mark-up – I think we’re in agreement here too – I like the in-line quotes, and can position them independently with CSS, but their parent <p> tags mean they start off on their own lines, and these <p> tags can’t really be targeted easily to set the height to 0 for instance.

Here’s what I’m getting:

<div class="testimonials-widget-testimonials listing">
	<div class="post-190 testimonials-widget type-testimonials-widget status-publish hentry testimonials-widget-testimonial list">
		<blockquote>
			<p><span class="open-quote"></span>
			<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque ut metus mi, vitae porttitor nunc.</p>
			<p><span class="close-quote"></span></p>
		</blockquote>
		<div class="credit">
			<span class="author">Joe Bloggs 2</span>
		</div>
	</div>
</div>

You can see that the <p> tags wrapping around the open/close spans would create their own new line when rendered, and it’s difficult to target these <p> tags to float them or whetever.

Incorrect nesting – as you’ll see above, there opening quote span has an opening <p> tag but no closing tag.

I looked at your gist and can see yours is fine. I’m working locally at the minute so can’t send you a link, but my theme is written from the ground up, there’s nothing special about it though, there should be nothing interfering with your plugin. My testimonials just have author (as the post name) and the quote itself (nothing has been added in the testimonial data meta box). All of the plugin settings were default, nothing is hidden via the settings.

I hope that helps to pin down the issue. If I get chance I’ll set up a demo link.

Thanks 🙂