WordPress.org

Ready to get started?Download WordPress

Forums

PB Responsive Images
Fallback for IE (7 posts)

  1. pezholio
    Member
    Posted 1 year ago #

    Hi,

    I've noticed that (for my use case anyway), this plugin doesn't work in IE. As per the Picturefill docs on supporting IE, I've added a line that, as well as adding a noscript fallback, adds a fallback image without a data-media attribute for IE 8 and older. You can see it here:

    https://gist.github.com/4483996

    Would be great if you could add it, or maybe advise if I'm doing it wrong.

    (By the way, it would be great if you could fork and do pull requests on plugins in the WordPress plugin directory - I think Github has spoilt me!)

    http://wordpress.org/extend/plugins/pb-responsive-images/

  2. Jacob Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Github has spoiled me as well - I wish I could do a compare on your pull request, and press one key to merge it.

    However, this plugin should work with IE; picturefill by itself has no IE support, but the bundled matchmedia polyfill provides media queries for IE. If it's not working, there may be a javascript error. Let me do some testing with the current build, and see if there's an issue.

  3. pezholio
    Member
    Posted 1 year ago #

    Cool, ta. I couldn't see any obvious JS errors, but I'm not the best when it comes to JavaScript!

  4. Jacob Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    I just did a check with the current build and it all checked out on IE6/7/8. Do you have a live link showing your issue? And what version of IE are you seeing this on?

  5. pezholio
    Member
    Posted 1 year ago #

    Here you go - I've commented out my hack, so it should be working normally:

    http://www2.lichfielddc.gov.uk/stjohns/

  6. Jacob Dunn
    Member
    Plugin Author

    Posted 1 year ago #

    Ok, well that clears it up. It's working in IE9, but IE8 is in fact failing - an oversight on my part. The reason I hadn't noticed on my site is we keep the media query on the fallback image blank, which works in IE8 and below. I'll take a look at your merge for sure, and see if there's a way to integrate it with the functions and administration. Thanks for the feedback!

  7. pezholio
    Member
    Posted 1 year ago #

    Excellent, thanks for the detailed help :)

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.